embersherpa / ember-element-resize-detector Goto Github PK

The current ember-cli-fastboot releases (1.0.0-rc.1 and above) introduce breaking changes. These will most likely break your current FastBoot implementation.

See ember-fastboot/ember-cli-fastboot#387 for more information and a guide on how to fix your addon. Also you may want to visit the -fastboot Slack channel to get help from other users.

Note: this issue has been created automatically, by searching for certain patterns in your code. If you think this has been falsely created, feel free to close!

I'm getting the following error when attempting to upgrade to Ember 3.2 which appears to come from
https://github.com/EmberSherpa/ember-element-resize-detector/blob/master/addon/components/resize-detector.js#L31

Uncaught Error: Assertion Failed: Attempted to call .sendAction() with the action 'on-resize' on the destroyed object '<ilios@component:resize-detector::ember199658>'.

Looks like the component resize-detector uses no tag

export default Ember.Component.extend({
  layout,
  tagName: '',
  resizeDetector: service(),
 ...

which causes this error in ember 2.8
ember.debug.js:6778 Uncaught Error: Assertion Failed: You cannot use attributeBindings on a tag-less component: <schema-ember@component:resize-detector::ember1957>

This issue comes up when using ember-scrollable ( which uses this add on )

DEPRECATION: ember-cli-babel 5.x has been deprecated. Please upgrade to at least ember-cli-babel 6.6. Version 5.2.8 located: site-xxx-> ember-light-table -> ember-scrollable -> ember-element-resize-detector -> ember-cli-babel

Hi All -
I'm trying to remove jquery from Ember Light Table (which is two dependencies upstream).

Hope you'd all consider this (I've done all the work)

• Remove instances of Ember.$ see #17
• Upgrade addon/tests See #18

Element resize detector adds the following block to the page which forces apps implementing CSP to relax their rules for styles making their app vulnerable. Is this something that can be avoided? May be add this as a vendor stylesheet?

<style id="erd_scroll_detection_scrollbar_style">
/* Created by the element-resize-detector library. */
.erd_scroll_detection_container > div::-webkit-scrollbar { display: none; }

.erd_scroll_detection_container_animation_active { -webkit-animation-duration: 0.1s; animation-duration: 0.1s; -webkit-animation-name: erd_scroll_detection_container_animation; animation-name: erd_scroll_detection_container_animation; }
@-webkit-keyframes erd_scroll_detection_container_animation { 0% { opacity: 1; } 50% { opacity: 0; } 100% { opacity: 1; } }
@keyframes erd_scroll_detection_container_animation { 0% { opacity: 1; } 50% { opacity: 0; } 100% { opacity: 1; } }
</style>

app.import is not a function
TypeError: app.import is not a function
    at Class.module.exports.included (/Users/nmcclay/git/light-table/node_modules/ember-light-table/node_modules/ember-element-resize-detector/index.js:20:17)
    at /Users/nmcclay/git/light-table/node_modules/ember-cli/lib/models/addon.js:244:32

I encountered this issue trying to upgrade ember-light-table and noticed this problem.

    if (!process.env.EMBER_CLI_FASTBOOT) {
      app.import('vendor/element-resize-detector/element-resize-detector.js');
    }