elwayman02 / ember-data-github Goto Github PK

View Code? Open in Web Editor NEW

47.0 2.0 38.0 1.76 MB

Ember Data library for the GitHub API

License: MIT License

JavaScript 97.72% HTML 2.25% CSS 0.03%

ember-data ember ember-addon emberjs github github-api

ember-data-github's People

Contributors

Stargazers

Watchers

Forkers

nainterceptor h55nick conorlinehan welldan97 alerdenisov gcarre alexbaizeau catchamonkey feedbackfruits topaxi devinrhode2 tdbunting astorise raulb srvance alexander-alvarez appleton ac-timrourke donaldwasserman dhaulagiri prasannavijayan joshwlewis jmar910 hakilebara nullvoxpopuli jabrown85 candidmetrics jaredgalanis mayo2943 willjthorp code0100fun vrialland silvrwolfboy devopskev crowjonah allicete imniafacji wycats

ember-data-github's Issues

An in-range update of broccoli-funnel is breaking the build 🚨

The dependency broccoli-funnel was updated from `2.0.1` to `2.0.2`.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

broccoli-funnel is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details

❌ continuous-integration/travis-ci/push: The Travis CI build could not complete due to an error (Details).

Commits

The new version differs by 14 commits.

fc12aaf Remove broken auto-publishing via preversion/postversion scripts
87c784d v2.0.2
48960a4 Add v2.0.2 to CHANGELOG.md.
00de4f4 Merge pull request #106 from chriskrycho/input-node-105
a793c0b Fix indentation in latest-added test.
6f031e3 Add test for creating nested output when missing input node.
67b2e2c Make an empty dir if missing but allowEmpty.
74f3454 Add test for available input node at missing source.
a76c4ee Handle empty src dir if allowEmpty with include/exclude.
c49cf8d Add failing test for include/exclude and empty input node.
bfea8d4 Merge pull request #102 from davewasmer/patch-1
0afbb9c Fix exclude option docs
0859618 Merge pull request #101 from reidab/patch-1
bfdd055 Update changelog for recent releases

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of bootstrap is breaking the build 🚨

🚨 Reminder! Less than one month left to migrate your repositories over to Snyk before Greenkeeper says goodbye on June 3rd! 💜 🚚💨 💚

Find out how to migrate to Snyk at greenkeeper.io

The devDependency bootstrap was updated from `4.4.1` to `4.5.0`.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

bootstrap is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

❌ continuous-integration/travis-ci/push: The Travis CI build could not complete due to an error (Details).

Release Notes for v4.5.0

Highlights

New interaction utilities. Quickly set user-select with the new utilities and Sass map.
New Reboot style for pointer cursors. We now include a role="button" selector in Reboot to set cursor: pointer on non-<button> element buttons.
Examples are now downloadable. We've added a script to zip up and offer all our Examples as their own download from the docs.
Added guidance to our docs for how to workaround our longstanding input group rounded corner bug.
Redesigned docs homepage and navbar to increment us towards v5's new docs design.
Deprecated bg-gradient-variant mixin as it's being removed in v5
Updated to jQuery v3.5.1, Jekyll v4, and dropped Node.js < 10.

CSS

#29413: Prevent vertical offset on progress bar in IE11
#29745: Add display: flex on .breadcrumb-item
#29819: Allow percentages in container widths
#29937: Add missing Noto Sans font to font stack
#29946: Added new variable for padding on dropdown header
#30004: Fixes disabled .btn cursor
#30036: Added focus state to .btn-link
#30043: Fix IE auto-size input-group to column
#30049: Prevent grid with default cols from breaking when large pre is present by setting min-width: 0
#30074: Use word-wrap in .text-break for IE and Edge compatibility.
#30166: Avoid border-radius functions returning negative values
#30183: Remove unnecessary reduce motion when $enable-transition: false
#30244: Fix centered modal scrolling issue
#30262: Prevent link underline change from affecting some components
#30361: Remove appearance from date inputs
#30391: Prevent redundant transition: none in transition()` mixin
#30497: Fix card list group borders & radii
#30504: Fix spinner-grow animation in Safari
#30515: Add .card-footer color
#30555, #30512, #30480: Use box-shadow mixin for .form-select, .btn, and other form controls
#30562: Added new interaction utilities for user-select and a new - role="button" in Reboot to set cursor: pointer.
#30582: Delete unncecessary appearance: none from button.close
#30594: Deprecate bg-gradient-variant mixin
#30605, #30606: Grid now checks for for $grid-columns > 0
#30609: Checks for an empty $grid-breakpoints map list to remove all breakpoints
#30660: Prevent list group style leaks
#30685: Disable auto-hiding scrollbar in legacy Edge
#30755: Removed role="document" from the modal dialog

JavaScript

#29968: sanitizer.js: Add srcset in the allowed attributes
#29969: Use regex.test() when we want to check for a Boolean on popovers/tooltips
#30381: Updated tab.js to address accessibility issue when using ul/li semantic
#30383: ensure totype always return stringified null when null passed
#30388: enable button toggle on label when checkbox is inside
#30490: Switch to string constants to save ~5% on file size
#30510, #30511: Fix event propagation from inactive and disabled dropdowns
#30744: ensure build plugins can exit in error
#30772: Prevent scrollbar replacement on non-integer width
22f75c: scrollspy: only accept valid Elements as input for target

Docs

Redesigned docs homepage
Improved tap target sizing in our navigation
Added examples for our input group border-radius workaround
Added warning to browser bugs page that it's no longer maintained
Added loading="lazy" for images
#29782: Improve wrapping and hit area of accordion example titles
#29820: move width after make-container() mixin
#29956: Add Microsoft Edge for macOS to supported browsers
#30130: Added ability to zip and download our Examples
#30175: Add version number in page title
#30180: Changed input group validation examples to reflect issues with input group.
#30207: Headings hierarchy in theming.md
#30325: Updated modal docs to simplify data-target usage and more
#30416: Clarify card group behavior
#30469: Remove holder.js leftovers
#30505: Use existing position utility in navbar example
#30695: make the check for URL stricter in our docs search

Examples

#29886: Fix checkout page forms
#30573: Improve the responsiveness of our Dashboard example

Dependencies

Updated jQuery to v3.5.1
Replaced bundlesize with bundlewatch
Updated to Jekyll v4
Drop Node.js < 10
Misc devDependencies updates

Commits

The new version differs by 153 commits.

7a6da5e Dist
109ad5d Bump version to 4.5.0.
4a0ddb0 Wording fixes
0f26be5 Move the input groups validation workaround in docs.
842b0d2 Remove mention of build tools
32932d2 Grammar fixes
4a26e51 Include the newly added utilities/interactions.scss file
0f3eda8 Update devDependencies and gems.
30e7df6 Backport d59de33 from #30772
f1827ce Avoid bad scrollbar replacement into width values
eb1df3e Update codeql.yml (#30777)
df91d2c Improve build/zip-examples.js (#30759)
d2f9fbd Removed role="document" from the modal dialog (#30755)
bad48dc CI: simplify cache
86f2c01 Partially revert "Use regex.test() when we want to check for a Boolean. (#29969)"

There are 153 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of ember-data is breaking the build 🚨

The devDependency ember-data was updated from `3.12.0` to `3.12.1`.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

ember-data is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

❌ continuous-integration/travis-ci/push: The Travis CI build could not complete due to an error (Details).

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

Design to support GitHub Trees API

I decided to use the Tree API rather than the Contents API to navigate the file tree in the repo. It's more concise in its response and seems to have fewer limits on its responses.

It's return is like

{
  "sha": "9fb037999f264ba9a7fc6274d15fa3ae2ab98312",
  "url": "https://api.github.com/repos/octocat/Hello-World/trees/9fb037999f264ba9a7fc6274d15fa3ae2ab98312",
  "tree": [
    {
      "path": "file.rb",
      "mode": "100644",
      "type": "blob",
      "size": 30,
      "sha": "44b4fc6d56897b048c772eb4087f854f46256132",
      "url": "https://api.github.com/repos/octocat/Hello-World/git/blobs/44b4fc6d56897b048c772eb4087f854f46256132"
    },
    {
      "path": "subdir",
      "mode": "040000",
      "type": "tree",
      "sha": "f484d249c660418515fb01c2b9662073663c242e",
      "url": "https://api.github.com/repos/octocat/Hello-World/git/blobs/f484d249c660418515fb01c2b9662073663c242e"
    },
    {
      "path": "exec_file",
      "mode": "100755",
      "type": "blob",
      "size": 75,
      "sha": "45b983be36b73c0788dc9cbcb76cbb80fc7bb057",
      "url": "https://api.github.com/repos/octocat/Hello-World/git/blobs/45b983be36b73c0788dc9cbcb76cbb80fc7bb057"
    }
  ],
  "truncated": false
}

I think it's clear that the id needs to be the SHA, even if it could cause some doubling of the model at the entry point when using something like a branch name instead of a SHA, e.g., https://api.github.com/repos/elwayman02/ember-data-github/git/trees/master.

I'm not sure how to model the tree array and its contents. They could be sorted into blobs and trees, although that may be better done as CPs. They have a relationship to other types but those types don't have the same representation as the data contained in the array. Something like ember-data-model-fragments might be appropriate.

Thoughts?

Add issues to track which APIs are supported

We need issues for each type of Github API, so we can figure out which endpoints work and which ones still need to be implemented in this addon.

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/32883127-add-issues-to-track-which-apis-are-supported?utm_campaign=plugin&utm_content=tracker%2F15732968&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F15732968&utm_medium=issues&utm_source=github).

Create demo

Build out dummy app with examples of APIs
Deploy via netlify

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Update Auth Example to use Modules

The auth example in the README imports Ember as a package instead of using the npm module imports.

Yarn changelog doesn't seem to do anything

@Dhaulagiri I'm not sure what I'm doing wrong, but running yarn changelog after pulling an unreleased version of master did not update the changelog with the latest commits.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

An in-range update of ember-cli-htmlbars is breaking the build 🚨

Version 1.2.0 of ember-cli-htmlbars just got published.

Branch	Build failing 🚨
Dependency	ember-cli-htmlbars
Current Version	1.1.1
Type	devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As ember-cli-htmlbars is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Status Details

❌ continuous-integration/travis-ci/push The Travis CI build failed Details

Commits

The new version differs by 5 commits .

fac427b 1.2.0
ee5bb76 Merge pull request #108 from ember-cli/pass-source-to-compilers
cae3b4f Allow AST plugins to access the raw template contents.
aa1b193 Merge pull request #106 from ember-cli/ci-deploy
caccae7 CI: Enable automatic NPM deployment for tags

See the full diff.

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.

Your Greenkeeper Bot 🌴

An in-range update of ember-data is breaking the build 🚨

The devDependency ember-data was updated from `3.4.0` to `3.4.1`.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

Status Details

❌ continuous-integration/travis-ci/push: The Travis CI build could not complete due to an error (Details).

Release Notes for Ember Data 3.4.1

Changelog (September 14, 2018)

#5621 Add partner test for the ilios frontend
#5589 fix broken link because the new API website does not support the anchor
#5582 [BUGFIX] Reference.reload should not cause sync-relationship assertion (#5582)
#5584 Additional test coverage for async belongsTo mutation (#5584)
#5592 Grammar fixes
#5602 Publish docs to npm (#5602)
#5620 [DOC release] Change misleading documentation for AdapterPopulatedRecordArray
#5622 remove deletes (#5622)
#5624 [BUGFIX] fix promise labels
#5627 [FEAT adapterOptions] Ensure adapterOptions use is possible throughout (#5627)
#5632 cleanup code climate config

Commits

The new version differs by 29 commits ahead by 29, behind by 4.

82a495a Release Ember Data 3.4.1
22a54f1 Merge pull request #5632 from emberjs/code-climate
71b3d90 [FEAT adapterOptions] Ensure adapterOptions use is possible throughout (#5627)
7df04db cleanup code climate config
23410a1 Merge pull request #5624 from emberjs/fix-labels
c1f050b prettier :/
5ad7df2 fix labels
1cac25e Merge pull request #5620 from happycollision/patch-1
b6af721 remove deletes (#5622)
a1dd055 Merge pull request #5621 from jrjohnson/test-ilios-frontend
411ab8a Show output for smoke tests
f8c0983 [DOC release] Fix misleading documentation: AdapterPopulatedRecordArray
56f6301 Add partner test for the ilios frontend
298a26e [FEAT] deprecate instead of assert method calls on a destroyed store instance (#5619)
b908b3a [FEAT] ensure release builds only perform necessary jobs

There are 29 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

Make default user token configurable

Wanted to see what you thought of this before I implement it. Using # as the token to indicate the default user makes it impossible to declare a route that passes that token because # has special meaning in URLs. Making the token configurable would let you redefine it in a declarative way that could work with URLs.

http://localhost:4200/user/elwayman02  // Standard usage with dynamic segment
http://localhost:4200/user/#  // Doesn't work because hashes have special meaning in URLs
http://localhost:4200/user/-  // Works for the URL, but requires additional route declaration

I propose a configuration parameter ENV['ember-data-github'].defaultUserToken that would be used if specified with # as the default.

Add support for listing pull requests from a repo

Would like to list PR's in public and private repos, either directly

this.get('store').findRecord('githubPullrequests', 'username/reponame'); // get a list of PR's

or after a repo request.

let repo = this.get('store').findRecord('githubRepository', 'jimmay5469/old-hash');
repo.githubRepositories

Would be happy to provide a PR for this if you can provide some detail on how you want it implemented?

Thanks.

An in-range update of ember-bootstrap is breaking the build 🚨

The devDependency ember-bootstrap was updated from `2.4.0` to `2.5.0`.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

ember-bootstrap is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

❌ continuous-integration/travis-ci/push: The Travis CI build could not complete due to an error (Details).

Commits

The new version differs by 40 commits.

7f99127 Released v2.5.0
b960183 Merge pull request #741 from kaliber5/hide-validations-onsubmit
0390b2f Fix #748: Bump bootstrap3 version to 3.4.0
4237eae Expand scenarios where BsButton click event will bubble (#747)
da34ea2 Merge pull request #746 from jelhan/fix-content-security-policy
ab3955f test should fail if violating CSP
f5b1914 fix: use stylesheet.deleteRule() which is covered by spec
04ba43b refactor(Popover): test should have styles before rendering
8ee056c relax CSP to allow expected iframe and bootstrap inline svg
a322869 whitelist frame-src https://ghbtns.com/ used in application template of dummy app
5572b4b fix(Tooltip): test should not violate CSP style-src 'none'
1e39704 refactor logic to insert CSS rules for testing
3174419 fix(Popover): test should not violate CSP style-src 'none'
6ea055e fix(Collapse): should not violate CSP style-src 'none'
fe26da3 fix(Progress): should not violate CSP style-src 'none'

There are 40 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

DRY up how attribute keys are decamelized

Once #53 lands we should refactor all the serializers such that the base github serializer overrides keyForAttribute and calls decamelize on each attribute, removing the need to do it for each property one-by-one in each model's serializer.

Make mirage config consumable by apps

I thought this was baked into mirage but found out today it is not: it would most helpful if apps consuming this addon could opt-in to reusing the same mirage factories/models/serializers to make it easier for them things in their apps a swell.

nypublicradio/nypr-publisher-lib#4 outlines how this can be done.

DRY up auth testing

Currently we have a lot of repeated code in acceptance tests confirm the auth token is sent with requests. This seems like the wrong level to be testing this as the acceptances are really just confirming that injecting the token into the adapter works which could be tested at a lower level once?

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Add tests for github pull requests

There are no tests around github pull requests

Remove references to Pretender

Now that we use mirage, we don't need to reach into the pretender server. These references can likely be removed as implied, or in some cases refactored to proper high-level mirage DSL.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Document addon usage in README

Add auto-publish script for ember-cli-release

Should publish to npm when a release is cut

An in-range update of ember-cli-babel is breaking the build 🚨

Version 5.2.2 of ember-cli-babel just got published.

Branch	Build failing 🚨
Dependency	ember-cli-babel
Current Version	5.2.1
Type	dependency

This version is covered by your current version range and after updating it in your project the build failed.

As ember-cli-babel is a direct dependency of this project this is very likely breaking your project right now. If other packages depend on you it’s very likely also breaking them.
I recommend you give this issue a very high priority. I’m sure you can resolve this 💪

Status Details

❌ continuous-integration/travis-ci/push The Travis CI build failed Details

Commits

The new version differs by 5 commits .

5526d86 5.2.2
cc9942a Merge pull request #108 from babel/add-annotation
74c4723 Add more detailed annotation.
10dc1cd Merge pull request #107 from twokul/patch-1
54db09a Brocfile.js -> ember-cli-build.js

See the full diff.

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.

Your Greenkeeper Bot 🌴

An in-range update of ember-data is breaking the build 🚨

The devDependency ember-data was updated from `3.10.0` to `3.11.0`.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

Status Details

❌ continuous-integration/travis-ci/push: The Travis CI build could not complete due to an error (Details).

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of ember-data is breaking the build 🚨

Version 2.11.1 of ember-data just got published.

Branch	Build failing 🚨
Dependency	ember-data
Current Version	2.11.0
Type	devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As ember-data is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Status Details

❌ continuous-integration/travis-ci/push The Travis CI build failed Details

Commits

The new version differs by 9 commits .

6a09497 Release Ember Data 2.11.1
d554a9b Update changelog for the Ember Data 2.11.1 release
4fa2775 Merge pull request #4791 from runspired/2.11-hotfix
0620290 don't remove unpersisted deletes
a9d93b0 Add a test for #4770
4d91aa4 [BUGFIX release] revert deletion of filter that removed deleted models when flushCanonical of hasMany was called
1803e97 Fixes _lookupFactory deprecation for Ember canary
56d4160 Do not access container if Ember.getOwner exists.
ffe093b Update deprecate arguments (#4760)

See the full diff.

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.

Your Greenkeeper Bot 🌴

How to get all users repos

I am newer to ember and I am trying to figure out how i can get access to all of my repositories through this ember data adapter. So far i am able to get ahold of my user data (and get authenticated) like so

// in /routes/profile/index.js
Ember.Route.extend({
  model() {
    return this.get('store').findRecord('github-user', '#');
  }
});

And then in my repos route (where i plan to show a list of repos)

// in routes/profile/repos.js

Ember.Route.extend({
  model() {
    const user = this.get('store').findRecord('github-user', '#');
    let repos = user.githubRepositories;

    return repos;
  }
});

Now I understand that user.githubRepositories will return an ember DS.PromiseManyArray promise, but I do not understand what type of promise code to use to actually get a hand on the repository data.

Any help would be appreciated, thanks!

Users model is missing some properties

Looking at the user model, there are a few missing.

An in-range update of ember-data is breaking the build 🚨

The devDependency ember-data was updated from `3.14.1` to `3.15.0`.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

Status Details

❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

Adding `commit` to the `github-branch` serializer

Hi @elwayman02!

I wanted to hear your thoughts in regards to something before I go ahead and open a PR.

I just started using your addon because I needed to fetch the information for GitHub branches, but among the name, I wanted to show also the latest commit message. Since I don't need to create a separate Commit model for now, what I'm doing is the following:

// ember-data-github/addon/serializers/github-branch.js

import GithubSerializer from './github';

export default GithubSerializer.extend({
  normalize(type, hash, prop) {
    hash = {
      id: hash.recordId || hash.commit.url.replace('https://api.github.com/repos/', '').replace(/\/commits\/.+/, `/branches/${hash.name}`),
      name: hash.name,
      commit: hash.commit
    };
    return this._super(type, hash, prop);
  }
});

// ember-data-github/addon/models/github-branch.js

import DS from 'ember-data';

export default DS.Model.extend({
  name: DS.attr('string'),
  commit: DS.attr()
});

Is there a reason not to do that, or did you have in mind leaving the option for creating a separate model for Commits?

Thanks!

Add example of retrieving github org to Readme

Ember 2.x

Any plans to update this to Ember 2.x and Ember-Data 2.x?

An in-range update of loader.js is breaking the build 🚨

Version 4.2.0 of loader.js just got published.

Branch	Build failing 🚨
Dependency	loader.js
Current Version	4.1.0
Type	devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As loader.js is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Status Details

❌ continuous-integration/travis-ci/push The Travis CI build failed Details

Commits

The new version differs by 14 commits .

cc53069 release v4.2.0
1a453d3 Merge pull request #104 from trentmwillis/redefine
93478ef Improve redefinition scenarios
e289916 Fix test:dev command
287a487 Merge pull request #105 from trentmwillis/clarify
cda1c29 Clarify prime comment
562ecf1 Merge pull request #100 from jrowlingson/master
6a9b916 remove petal references
b609262 Merge pull request #95 from chadhietala/heimdall-instrumentation
c49296d Instrument with heimdall
453fe8c Merge pull request #97 from Turbo87/ci-deploy
37fef79 CI: Enable automatic NPM deployment for tags
c4f0755 Merge pull request #96 from chadhietala/dict-registry
8a34296 Use dict for registery and seen to avoid filling IC cache

See the full diff.

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.

Your Greenkeeper Bot 🌴

Consider renaming user property on release model to author

The name of the property in this addon is user but in the actual github payload it is referred to as author.

ember-data-github/addon/models/github-release.js

Line 19 in 0989d8b

user: DS.belongsTo('githubUser', {

Add Files Model

This is currently treated as a blob object in the tree model: https://github.com/elwayman02/ember-data-github/blob/master/addon/models/github-tree.js#L6

If we can define its shape, we should do so.

This seems like a more useful 1.0 candidate than supporting entirely new APIs that we haven't begun implementing yet.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Move to ember-cli-mirage testing

Right now we use a bespoke Pretender setup at a lower level than mirage, which would simplify a lot of our test code and make it easier to reuse.

Be more consistent about relationship name properties

There is a lack of consistency around whether a relationship property is prefixed with github or not. In some cases we do and others we don't.

ember-data-github/addon/models/github-organization.js

Line 7 in 0989d8b

githubUsers: DS.hasMany('githubUsers', { async: true }),

ember-data-github/addon/models/github-repository.js

Line 22 in 0989d8b

branches: DS.hasMany('githubBranch', { async: true }),

An in-range update of ember-cli-qunit is breaking the build 🚨

Version 3.1.1 of ember-cli-qunit just got published.

Branch	Build failing 🚨
Dependency	ember-cli-qunit
Current Version	3.1.0
Type	devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As ember-cli-qunit is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Status Details

❌ continuous-integration/travis-ci/push The Travis CI build failed Details

Commits

The new version differs by 7 commits .

f4cbeb9 3.1.1
f2f997c Merge pull request #170 from hidnasio/override-height-in-fullscreen
cbb2d8d Override height in full-screen mode
e9bd941 Merge pull request #167 from trentmwillis/rename
d3ea9cf Change addon name from Ember CLI QUnit to ember-cli-qunit
3853663 Merge pull request #166 from Turbo87/ci-deploy
5bc45cd CI: Enable automatic NPM deployment for tags

See the full diff.

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.

Your Greenkeeper Bot 🌴

Add Directories Model

This is currently treated as a blob object in the tree model: https://github.com/elwayman02/ember-data-github/blob/master/addon/models/github-tree.js#L7

If we can define its shape, we should do so.

This seems like a more useful 1.0 candidate than supporting entirely new APIs that we haven't begun implementing yet.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Organization members are different than users?

Currently the members relationship on an organization is using the github-user model however in practice members and users are not quite the same thing when retrieved via the github api.

The member payload looks like this:

[
  {
    "login": "octocat",
    "id": 1,
    "avatar_url": "https://github.com/images/error/octocat_happy.gif",
    "gravatar_id": "",
    "url": "https://api.github.com/users/octocat",
    "html_url": "https://github.com/octocat",
    "followers_url": "https://api.github.com/users/octocat/followers",
    "following_url": "https://api.github.com/users/octocat/following{/other_user}",
    "gists_url": "https://api.github.com/users/octocat/gists{/gist_id}",
    "starred_url": "https://api.github.com/users/octocat/starred{/owner}{/repo}",
    "subscriptions_url": "https://api.github.com/users/octocat/subscriptions",
    "organizations_url": "https://api.github.com/users/octocat/orgs",
    "repos_url": "https://api.github.com/users/octocat/repos",
    "events_url": "https://api.github.com/users/octocat/events{/privacy}",
    "received_events_url": "https://api.github.com/users/octocat/received_events",
    "type": "User",
    "site_admin": false
  }
]

Whereas a user looks like this:

{
  "login": "octocat",
  "id": 1,
  "avatar_url": "https://github.com/images/error/octocat_happy.gif",
  "gravatar_id": "",
  "url": "https://api.github.com/users/octocat",
  "html_url": "https://github.com/octocat",
  "followers_url": "https://api.github.com/users/octocat/followers",
  "following_url": "https://api.github.com/users/octocat/following{/other_user}",
  "gists_url": "https://api.github.com/users/octocat/gists{/gist_id}",
  "starred_url": "https://api.github.com/users/octocat/starred{/owner}{/repo}",
  "subscriptions_url": "https://api.github.com/users/octocat/subscriptions",
  "organizations_url": "https://api.github.com/users/octocat/orgs",
  "repos_url": "https://api.github.com/users/octocat/repos",
  "events_url": "https://api.github.com/users/octocat/events{/privacy}",
  "received_events_url": "https://api.github.com/users/octocat/received_events",
  "type": "User",
  "site_admin": false,
  "name": "monalisa octocat",
  "company": "GitHub",
  "blog": "https://github.com/blog",
  "location": "San Francisco",
  "email": "[email protected]",
  "hireable": false,
  "bio": "There once was...",
  "public_repos": 2,
  "public_gists": 1,
  "followers": 20,
  "following": 0,
  "created_at": "2008-01-14T04:33:35Z",
  "updated_at": "2008-01-14T04:33:35Z"
}

Using the same model for both doesn't break anything however the model is largely empty when filled with member data. Perhaps this isn't a problem, but it seems potentially confusing if you are expecting to be able to use certain properties off the model in both cases?

Add `yarn changelog` command to the pre-commit hook for ember-cli-release config

This will keep the release process down to the single ember release command still.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

elwayman02 / ember-data-github Goto Github PK

ember-data-github's People

Contributors

Stargazers

Watchers

Forkers

ember-data-github's Issues

The dependency broccoli-funnel was updated from 2.0.1 to 2.0.2.

The devDependency bootstrap was updated from 4.4.1 to 4.5.0.

Highlights

CSS

JavaScript

Docs

Examples

Dependencies

The devDependency ember-data was updated from 3.12.0 to 3.12.1.

Version 1.2.0 of ember-cli-htmlbars just got published.

The devDependency ember-data was updated from 3.4.0 to 3.4.1.

Changelog (September 14, 2018)

The devDependency ember-bootstrap was updated from 2.4.0 to 2.5.0.

Version 5.2.2 of ember-cli-babel just got published.

The devDependency ember-data was updated from 3.10.0 to 3.11.0.

Version 2.11.1 of ember-data just got published.

The devDependency ember-data was updated from 3.14.1 to 3.15.0.

Version 4.2.0 of loader.js just got published.

Version 3.1.1 of ember-cli-qunit just got published.

Recommend Projects

Recommend Topics

Recommend Org

The dependency broccoli-funnel was updated from `2.0.1` to `2.0.2`.

The devDependency bootstrap was updated from `4.4.1` to `4.5.0`.

The devDependency ember-data was updated from `3.12.0` to `3.12.1`.

The devDependency ember-data was updated from `3.4.0` to `3.4.1`.

The devDependency ember-bootstrap was updated from `2.4.0` to `2.5.0`.

The devDependency ember-data was updated from `3.10.0` to `3.11.0`.

The devDependency ember-data was updated from `3.14.1` to `3.15.0`.