elliotstokes / gpx-parse Goto Github PK

TypeError: Cannot read property 'forEach' of undefined at ...\node_modules\gpx-parse\lib\gpx-parse.js:96:27

Will try to provide a PR

Looking for a gpx parser, i came across yours. Just a note from the first impression:

gpxParse.parseGpxFromFile("/path/to/gpxFile", function(error, data) {
	//do stuff
});

Writing //do stuff hardly gives any hint as to what this does. Is it a pull parser? is it a tree parser? Is it an event driven parser?

If you care, it would do your audience a favour if you pasted one of your test code snippets. It is a tree parser.

The devDependency grunt-jsdoc was updated from 2.4.0 to 2.4.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

grunt-jsdoc is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

☝️ Important announcement: Greenkeeper will be saying goodbye 👋 and passing the torch to Snyk on June 3rd, 2020! Find out how to migrate to Snyk and more at greenkeeper.io

The devDependency grunt was updated from 1.0.4 to 1.1.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

grunt is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Version 10 of Node.js (code name Dubnium) has been released! 🎊

To see what happens to your code in Node.js 10, Greenkeeper has created a branch with the following changes:

• Added the new Node.js version to your .travis.yml

If you’re interested in upgrading this repo to Node.js 10, you can open a PR with these changes. Please note that this issue is just intended as a friendly reminder and the PR as a possible starting point for getting your code running on Node.js 10.

Your Greenkeeper Bot 🌴

I would like to use this library with a create-react-app application. However, when I import it, I get the following error:

Module not found: Error: Can't resolve './lib-cov/gpx-parse' in '/Users/me/js/jespr-web/node_modules/gpx-parse'

When I make the following change to index.js, it works:

- module.exports = process.env.GPXPARSE_COV ? require('./lib-cov/gpx-parse') : require('./lib/gpx-parse');
+ module.exports = require('./lib/gpx-parse');

It seems like the require statement is evaluated even then process.env.GPXPARSE_COV is false. Can we remove this check?

Hi,

when I use the lib via bower, there are no errors thrown, but the gpxParse is not available.
I'm not sure but I think if the index.js does not actually load all modules the bower.json should point to a compiled version for the browser in its main attribute.

Thanks,
Chris

Hi again,

I have a .gpx file which only contains waypoints. When I try to parse it I get a TypeError: Cannot read property 'length' of undefined. Usually I would post the contents of the file, but in this case they contain commercial property, so... do you mind if I send it to you via email?

Thanks,
Chris

The devDependency coveralls was updated from 3.0.6 to 3.0.7.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

coveralls is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

I'm trying to use your GPX Parser in one of my project : https://github.com/Wilkins/gpx-simplify-optimizer
In the project, I simplify a geometry to reduce the number of points in a track/segment.
Your parser is working nicely. But I would like to know if there is a way to put the GPX data back into a XML string ? Either with your project, or maybe with another NodeJS library.
Thanks

Hi there, thank you so much for this library, it's super useful.

Is there an option for the parser to return km rather than miles? I see the software is hard-coded to use miles for distances (track lengths etc) but meters for elevations. Wouldn't it make more sense to return everything in metric or everything in imperial?

if so, would you accept a PR that defaults to metric?

Thanks

Dario

The dependency xml2js was updated from 0.4.19 to 0.4.20.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

xml2js is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

1. Previously the Waypoint creation in gpxParse did not pass the XML-extracted parameter for cmt, so any comment in the waypoint XML was not associated with the new GpxWaypoint.
   gpx-parse.js > L31:

var point = new GpxWaypoint(wayPoint.$.lat, wayPoint.$.lon, getFloat(wayPoint.ele), wayPoint.time, null, null, getString(wayPoint.name), null, getString(wayPoint.desc));

gpxWaypoint > L19:

function GpxWaypoint(lat, lon, elevation, time, magvar, geoidheight, name, cmt, desc, src, links, sym, type) {

2. There are also a few schema elements in the GPX 1.1 Waypoint schema not yet supported or implemented by the parser: magvar, geoidheight, cmt, src, links, sym, type, fix, hdop, vdop, pdop, ageofdgpsdata, dgpsid.

Hello.

Could you comment this, please?
https://github.com/elliotstokes/gpx-parse/blob/v0.10.3/lib/gpx-parse.js#L31

Hey Elliot,

thanks for writing and sharing gpx-parse. Works great in Node.js!

I tried to browserify your module so that I can use it in the browser as well without any API modifications. Unfortunately that did not work. There are missing source files in the repository. The culprit is the ternary operator within index.js.

Browserify fails here because it seeks for all require statements in order to embed the dependencies. The first require statement imports a module which does not exist in the source tree. Is this intended? This statement will also fail in a Node.js environment if the respective environment variable is set.

process.env.GPXPARSE_COV ? require('./lib-cov/gpx-parse') : require('./lib/gpx-parse');

Maybe we could commit a skeleton directory which emulates that what will be injected by jscoverage/JSCover.

/André

Hi there,

http://www.vapidspace.com/gpx-parse/doc/GpxWaypoint.html states that member elevation is a number. However, when I parse a GPX file I get an array with only a single item which then is a number.

Thanks so much for this parser. I have been looking for one for quite some time now!

Thanks,
Chris