ella / ella-flatcomments

Flat comments for CMS ella utilizing redis for speed.

Ella Flat Comment

Flat comments for CMS ella utilizing redis for speed.

Build status

Master branch:

ella-flatcomments's Issues

Cannot Reply to a Comment

There does not appear to be an URL pattern to allow users to reply to an existing comment it currently exists in ella-comments here: https://github.com/ella/ella-comments/blob/master/ella_comments/urls.py#L13

Update Comment URL Name Change

Not a huge deal because we can just update our templates accordingly, but the comment-update url name has been modified in ella-flatcomments.

The URL in Ella Comments:
url(r'^%s/(?P<comment_id>\d+)/$' % slugify(_('update')), update_comment, name='comments-update'),

The URL in Ella FlatComments:
url(r'^(?P<comment_id>\d+)/%s/$' % slugify(_('update')), post_comment, name='comment-update')

Note the difference between comments-update and comment-update. I personally like comment-update better, but others using this library might not like the lack of backwards compatibility.

Keep me posted on whether or not this gets changed as we'll have to modify templates on our end to match the url name :)

Supply A Template Name When Posting a New Comment

It would be nice to be able to specify a template_name with the post data when calling ella_flatcomments.views.post_comment() => ella_flatcomments.views.get_template() in order to override the default template returned on a per request basis.

Currently, the only way to override the template is to attach a get_templates() method to the object that the comment is associated to.

Use Case: I have an issue in which a Publishable can be rendered in two places (in the forums and via its regular object detail view). We use different templates to render comments in each place. Assigning a get_templates() method to my Publishable won't solve this because the template that is to be returned needs to be dynamic based on where the request is coming from. Ie: If the comment is made in the forums, render the forum comment template. If the comment is made on the object detail page, render the regular comment template.

Proposal:
Pass the request object to get_templates():

ella_flatcomments/views.py:

def get_template(name, request, obj=None, async=False):
    if request.POST.get('template_name', None):
        return request.POST.get('template_name')
    if async:
        name = '%s_async.%s' % tuple(name.rsplit('.', 1))
    if hasattr(obj, 'get_templates'):
        return obj.get_templates(name)
    return get_templates_from_publishable(name, obj)

I don't mind creating a pull request if you feel this a reasonable feature enhancement. If there is another way to accomplish this, please let me know.

Updating a Comment Creates a New Comment

Looks like updating (editing) a comment results in a new comment getting posted and the old comment not being modified.

Screencast of the Issue:
http://cl.ly/1a36183p2G1b

Posting New Comment Via Ajax Returns Entire Comment List

Posting a new comment (via ajax) returns not only the newly posted comment, but the entire list of comments for the content object.

Screencast: http://cl.ly/3v2I3g0H3T3z