ella / ella-comments

Comments plugin for Ella CMS

Comments plugin for Ella CMS

Simple threaded comments plugin for Ella CMS. Internally uses https://github.com/HonzaKral/django-threadedcomments as comments provider.

Module is dependent on Ella CMS, so be sure to install it before this module.

ella-comments's Issues

Enable the template tags to accept content_type_id & object_pk

sometimes (for example in search results) you have access to ct_id, object_id pairs and want to display a list of comments/comment counts etc...

Create and send a "comment_removed" signal

django.contrib.comments sends a comment_was_posted signal when a new comment is created. Marking a comment as removed (is_removed=True) should send a comment_removed signal for third party apps that need to take into account a comment being removed from the system.

get_comment_options tag breaks include/with tag behavior

The get_comment_options tag calls .update() on the context, but never pops the context off. The leads to problems if the get_comment_options tag is called within a template that has been included or that is wrapped in a {% with %} tag. For example:

{% with foo as bar %}            # adds a new dictionary to the context with "bar" as a key.
    {% get_comment_options %}    # adds a new dictionary to the context
{% endwith %}                    # pops the dictionary that get_comment_options added, but not the one that the with added

Use numbers for comment count from redis if enabled

listing_hander comment_pre_save signal doesn't work with fixtures

If an primary key is explicitly set on a comment instance that isn't already saved, the comment_pre_save signal in listing_handlers will raise an error. This is most noticeable when loading comment data from fixtures as you must supply a primary key.

Wrapping https://github.com/ella/ella-comments/blob/master/ella_comments/listing_handlers.py#L35 in a try/except fixes the issue:

try:
    old_instance = instance.__class__._default_manager.get(pk=instance.pk)
except instance.__class__.DoesNotExist:
    return

Create an Absolute Url for Comments

Create an absolute url for comments so we can provide a more contextual environment for how a single comment is displayed.

Without this, the default pattern has been to link back to the absolute_url of the content_object that the comment is associated to. This isn't ideal as it could take the user a number of clicks to try to find the corresponding comment via pagination.

Proposed Solution:

1. Create a view/url that takes a comment_id and gets the comment as well as the page on which it can be found; then redirects the user to that comment's content_object.get_absolute_url() passing both the comment_id and p as GET params.
2. Optionally modify the comment detail template(s) to add <a name='{{ comment.id }} /> tags next to each comment so that the user can be directed to the comment requested without having to scroll. Optionally highlight the specified comment to make it easy for them to spot.