elixir-sensors / bmp280 Goto Github PK

That value was added before #21.

Currently Bosch BMP280 link is broken in README. The other links are good.

Catalog: https://www.bosch-sensortec.com/products/environmental-sensors/pressure-sensors/bmp388/
Data sheet: https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bmp388-ds001.pdf
Github: https://github.com/BoschSensortec/BMP3-Sensor-API
Adafruit: https://www.adafruit.com/product/3966

I saw this in the Neves Livebook when no sensor is connected.

This happens because we initialize the sensor in handle_continue. The error followed by {:ok, pid} result is a little confusing from the library user perspective, but I guess it is a matter of our design decision.

If we initialize the sensor in init callback not in handle_continue, we can return :error in case something goes wrong in the sensor initialization but then caller process would need to wait until the whole initialization gets completed.

To me personally from users perspective, I prefer to return {:error, reason} over always return {:ok, pid} unless initialization is painfully slow.

• Maybe it is OK and acceptable as a feature in favor of quick initialization? 🤔
• Maybe we can at least raise descriptive custom error message instead of the generic match error