elixir-makeup / makeup_erlang Goto Github PK

Fix function names when they are "builtins" (maybe will be solved by tokenizing a function name (function/arity))

Screenshot

Erlang prompt by default is 1> , 2> , etc. Let's make it unselectable, similarly to how iex> is treated.

When we get to a point where we can use this package to highlight erlang code in ex_doc, we should create a release of this package in Hex as to not include the dependency straight from github.

https://github.com/tmbb/makeup_erlang/blob/04751d8ce7dba517dfa9bc6cf6a0076071e8cd41/lib/makeup/lexers/erlang_lexer.ex#L125-L131

The only reason we might need the lexeme is if we need to pattern match on variable names later, for grouping purposes, for example. I believe I do that in the Elixir lexer (I haven't looked at the source in some time).

I get the following when compiling:

warning: Application.get_env/3 is discouraged in the module body, use Application.compile_env/3 instead
Warning:   lib/makeup/lexers/erlang_lexer.ex:250: Makeup.Lexers.ErlangLexer

Couple improvements that I think would be nice to do (referencend from this comment).

Improvements

• Highlight the module in a function call module:function() (example)
• Improve the module attribute combinator to handle specs -spec function(type()) -> type(). (example)
• Add a combinator for record like syntax #record{attribute = value} (example)

Maybe improvements?

(Things I would like to discuss)

• Have a combinator for function names function/0?
• Highlight attributes (binary, bitstring, number of bytes) in binary pattern match <<"string", Rest/binary>>? (I'm pretty ok with the way it is)

The license is stated as "BSD" in mix.exs. Anyhow, there are many different versions of this the BSD license. Which one excly is it?