eliteasian123 / banneradditions

Create custom banner patterns for Minecraft (1.15.2, 1.16.x)

banneradditions's Issues

Server Error On Join

[20:11:39] [Netty Server IO #3/ERROR] [minecraft/NettyPacketEncoder]: java.lang.NullPointerException
[20:11:39] [Netty Server IO #3/ERROR] [minecraft/ArgumentTypes]: Could not serialize net.minecraftforge.server.command.ModIdArgument@280a0090 (class net.minecraftforge.server.command.ModIdArgument) - will not be sent to client!
[20:11:39] [Netty Server IO #3/ERROR] [minecraft/ArgumentTypes]: Could not serialize net.minecraftforge.server.command.EnumArgument@453c9950 (class net.minecraftforge.server.command.EnumArgument) - will not be sent to client!

IllegalStateException from Missing Required Tags

Caused by: java.lang.IllegalStateException: Missing required tags: items:forge:dyes/black,items:forge:dyes/blue,items:forge:dyes/brown,items:forge:dyes/cyan,items:forge:dyes/gray,items:forge:dyes/green,items:forge:dyes/light_blue,items:forge:dyes/light_gray,items:forge:dyes/lime,items:forge:dyes/magenta,items:forge:dyes/orange,items:forge:dyes/pink,items:forge:dyes/purple,items:forge:dyes/red,items:forge:dyes/white,items:forge:dyes/yellow

This happens when custom datapacks are added. Mod based datapacks are fine.

40x Textures (or higher)

Does this mod support higher-resolution banner patterns? Currently a banner is 20px wide, looks like, and I'm curious whether I could implement patterns with more detail by simply scaling the texture up in multiples of 100%.

Incompatibility with "More Waterlogging" mod (1.16.1)

The More Waterlogging mod allows many more types of blocks to be waterlogged (much like Bedrock edition), and one of these block types is banners.
When using More Waterlogging with BannerAdditions, the game fails to load, with the error:

Banner Additions (banneradditions) encountered an error during the load_registries event phase
Invalid vanilla replacement. See log for details.

I'd love to use BannerAdditions, but More Waterlogging is a bit more important for me. If possible, please fix this compatibility issue, and if you do please fix it in the 1.16.1 version! So many mods have yet to update past that version, so many people are stuck there until they do.
I've included a screenshot of the load error, as well as the game log. The only two mods installed here were BannerAdditions and More Waterlogging, game version 1.16.1, Forge version 32.0.108.

• latest.log

Small error on the wiki

In the list of used IDs, you list diagonal_up_right as rd and diagonal_right as rud. Logic tells this should be reversed.

I mean, both IDs and hashes are already used either way, but just in case someone uses the list for creating banners through commands (since it's a nice and mostly clean overview).

Incompatibility with banner patterns added by other mods (1.16.1)

The mod Neapolitan adds many things, including one new banner pattern of a monkey. When using Neapolitan and BannerAdditions together, the monkey pattern doesn't work on banners— I can't even place it in the loom.
This is a very small bug and isn't gamebreaking by any means, but I thought I'd report it, because I figure if BA is incompatible with one mod-added banner pattern, it's probably incompatible with all mod-added banner patterns. Unfortunately I can't 100% confirm that, as Neapolitan is the only other mod I personally use that adds a new pattern.

---

Without BannerAdditions installed:

With BannerAdditions installed:

(Oh and uh, apologies for reporting a new bug immediately after you fixed the last one I reported 😅 Your mod is just the only one of its kind for recent Minecraft versions, so I'd love to help it be the best it can be!)

[Question] Future plans for compatibility with Bedspreads?

I came across this mod while browsing through CurseForge, and I think it looks cool. However, I saw on the mod page that it isn't compatible with Bedspreads, which is something we already have in our modpack. Is that due to some conflict between the two mods in how they modify banner functionality, or is it simply something you noticed and have on a "do something about this in the future maybe" list? I'd love to use both mods, but understand if there's a technical reason why they cannot be made to work together.

Can't load datapack

Wiki Suggestion: Advise to Use World Resourcepacks

Any resourcepack can be loaded as top-level resourcepack for a single world by placing it in the world save folder (the same where the per-world datapacks folder is located) as resources.zip. This will apply the resourcepack on top of all other resourcepacks upon world loading, make the player unable to remove that resourcepack manually (or put any resourcepack above it), and automatically remove the resourcepack as the respective world is left. Something similar can also be done for servers, although MineCraft will then ask the player for permission to download and apply the resourcepack. Given the nature of datapacks (although I heard 1.16 has a global location for them as well?), this would probably be the best approach, and I suggest it to be the recommended approach as per the Wiki.

[1.16.5] Small incompatibility between BannerAdditions 1.5.1 and Savage & Ravage 3.1.0

The mod Savage & Ravage has an alternative way to start a Raid, by burning an Ominous Banner with a Flint & Steel or Fire Charge. While BannerAdditions is installed, it is impossible to start a Raid this way as the banner cannot be set on fire.

Supplementaries Flags can no longer be put into the loom

This is more of an incompatability than anything, but it would be really nice to see this added/fixed

Crash when rendering entities with banners on main menu with Menu Companions mod

Hi, so one of my users has an issue where all sorts of illagers will sooner or later refuse to render on the main menu. We found that this is caused by patrol leaders which wear a banner. A crash-report also reveals that the error occurs inside of this mod.

Most issues with Menu Companions arise from the client player and world not being set yet, so maybe this is where this mod fails, too? Would it be possible to add some sort of null check? I have not looked into your code too much to be able to suggest where it might be necessary.

Here is a link with some more information and the crash-report: Fuzss/menucompanions#8 (comment)