Comments (5)
this is also an issue for other object types. e.g. i get two notifications for comments on videolist items that i have added to the site, one from videolist and one from mentions. it would be better if the two were combined.
from mentions.
In the latter case, the poster should not be mentioning you in the first place, because it's your post and therefore you're receiving a notification in any case. So technically it's working as intended and it's a mistake of the end user.
But I guess mentions could be altered to check the owner of the container, and send the notification only if notification recipient is not the owner.
from mentions.
if there is a thread under a video, for example, it is common for multiple people to be involved and for one commenter to want to target a specific person with their current comment and not anyone else. this is why you will see the original poster being mentioned in a comment thread under their item. if you look at youtube comments with threaded conversations you will see this in action a lot.
it would be best to send the mention notification in all cases, since it is possible to have multiple mentions for the same item and for them all to be relevant.
from mentions.
So you would want to prevent the "You have a new comment" notification but not the mentions notification?
This is something that must be implemented in a separate plugin, as otherwise Elgg core would contain feature that is specific to an individual plugin that isn't even bundled within Elgg. Additionally different sites have different needs, so we cannot force a behavior like this through the core.
You can make a plugin that uses e.g. the 'enqueue', 'notification'
hook to check whether the post owner is mentioned in the comment, and prevent the regular notification in that case.
from mentions.
i would suggest just having a notification that combines the comment and the mention into one single one. i thought mentions was intended to be included in core? if so, then this would be an aspect of it that would not be specific to any 3rd party plugin as it would apply equally to comments for blogs, pages or anything else.
from mentions.
Related Issues (20)
- More extensibility hooks HOT 1
- Could not save mentions settings. HOT 2
- @username is not converted to hyperlinked user name in river/activity HOT 2
- Make notification settings consistent HOT 4
- Integrate parser & unit tests
- Insert link client side instead of parsing @syntax server-side HOT 11
- Add setting to disable autocomplete HOT 2
- the name in the auto-fill/suggestion has become non-clickable.with Elgg 1.9.6 HOT 6
- Upgrade Request : Elgg 1.9.6 version please HOT 1
- How do I hyperlink @name to profile page within widgets?
- add transifex support
- user icons for mentioned usernames only appear if blog comment is edited HOT 1
- autocomplete for usernames is broken HOT 5
- Typo on settings page HOT 1
- Mentions notifications being sent to everyone? HOT 3
- Picking a name from the dropdown doesn't focus back to CKEditor
- Receiving messages about mentions that do not mention me... HOT 5
- mention in comment should link to comment and not to entity HOT 6
- every group member receive email notification when only mention one member in group discussion reply HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mentions.