Coder Social home page Coder Social logo

Comments (5)

propertunist avatar propertunist commented on August 12, 2024

this is also an issue for other object types. e.g. i get two notifications for comments on videolist items that i have added to the site, one from videolist and one from mentions. it would be better if the two were combined.

from mentions.

juho-jaakkola avatar juho-jaakkola commented on August 12, 2024

In the latter case, the poster should not be mentioning you in the first place, because it's your post and therefore you're receiving a notification in any case. So technically it's working as intended and it's a mistake of the end user.

But I guess mentions could be altered to check the owner of the container, and send the notification only if notification recipient is not the owner.

from mentions.

propertunist avatar propertunist commented on August 12, 2024

if there is a thread under a video, for example, it is common for multiple people to be involved and for one commenter to want to target a specific person with their current comment and not anyone else. this is why you will see the original poster being mentioned in a comment thread under their item. if you look at youtube comments with threaded conversations you will see this in action a lot.
it would be best to send the mention notification in all cases, since it is possible to have multiple mentions for the same item and for them all to be relevant.

from mentions.

juho-jaakkola avatar juho-jaakkola commented on August 12, 2024

So you would want to prevent the "You have a new comment" notification but not the mentions notification?

This is something that must be implemented in a separate plugin, as otherwise Elgg core would contain feature that is specific to an individual plugin that isn't even bundled within Elgg. Additionally different sites have different needs, so we cannot force a behavior like this through the core.

You can make a plugin that uses e.g. the 'enqueue', 'notification' hook to check whether the post owner is mentioned in the comment, and prevent the regular notification in that case.

from mentions.

propertunist avatar propertunist commented on August 12, 2024

i would suggest just having a notification that combines the comment and the mention into one single one. i thought mentions was intended to be included in core? if so, then this would be an aspect of it that would not be specific to any 3rd party plugin as it would apply equally to comments for blogs, pages or anything else.

from mentions.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.