elgentos / frontend2fa Goto Github PK

Hello,

currently there's no php7.4 compatibility:

- juashyam/authenticator 0.0.1 requires php ~5.5.0|~5.6.0|~7.0.0|~7.1.0|~7.2.0|~7.3.0 -> your php version (7.4.24) does not satisfy that requirement.
- elgentos/frontend2fa 0.1.10 requires juashyam/authenticator 0.0.1 -> satisfiable by juashyam/authenticator[0.0.1]

With Magento 2.4.4 there will be official PHP 8.1 support, so this should be considered as well.

endroid/qr-code is already bundled with Magento since 2.2.6 since the Magespecialist 2 factor authentication module uses it.

We now generate the QR code and check the 6-digit code using a Google Charts implementation. It would be nice to swap it with endroid/qr-code.

I cannot scan qr-code with google authenticator as it throws error message saying that the barcode is invalid and 'secret is not a token for authentication'

See screenshot here:
juashyam/2-Factor-Authentication#7

...instead of being dependent on https://github.com/juashyam/2-Factor-Authentication/

for some reason the composer will place this ext to both:
app/code/... and vendor/...
php bin/magento module:enable Elgentos_Frontend2FA will fail:

php bin/magento module:enable Elgentos_Frontend2FA Autoload error: Module 'Elgentos_Frontend2FA' from '/Users/yannislivasov/www/http/altcheckout/app/code/Elgentos/Frontend2FA' has been already defined in '/Users/yannislivasov/www/http/altcheckout/vendor/elgentos/frontend2fa'.

The same your friend's module juashyam/authenticator (or Neyamtux_Authenticator) does
The setup completed when I removed one copy from app/code

Hi @peterjaap if you're happy with the recent commits would you mind tagging the latest as a new release? Trying to avoid 'dev-master' in our composer versions :)