elevenpaths / easydoh Goto Github PK

The following line in the install.sh command will fail on macOS.

sed -i -e "s|HOST_PATH|$ESCAPED_HOST_PATH|" "$TARGET_DIR/$HOST_NAME.json"

macOS expects an extension name after the -i parameter per the man page:

     -i extension
             Edit files in-place, saving backups with the specified extension.  If a zero-length extension is given,
             no backup will be saved.  It is not recommended to give a zero-length extension when in-place editing
             files, as you risk corruption or partial content in situations where disk space is exhausted, etc.

In this script, it grabs the -e to use for the extension, resulting in an output file of com.elevenpaths.easydoh.json-e

On macOS, if the user removes the downloaded 'app' folder, the dependency of the easydoh.py script is removed with it. The script should be installed into a dedicated path outside of a transient folder location.

The com.elevenpaths.easydoh.json show the following after running a (modified: #2) version of the install.sh script

{
  "name": "com.elevenpaths.easydoh",
  "description": "Easy DNS over HTTPS agent",
  "path": "/Users/<redacted>/Downloads/app/macOS-Linux/easydoh.py",
  "type": "stdio",
  "allowed_extensions": [ "[email protected]" ]
}