Comments (2)
Thanks for bringing this up and sharing the related issue.
In our internal version of EASTL I recently added tests for allocator propagation because we don't have documentation on the allocator propagation behaviour (see propagate_on_X types from AllocatorAwareContainer). EASTL doesn't have the allocator traits class and instead has the same propagation behaviour for all allocators. The results of my testing were:
- propagate_on_container_copy_assignment::value is equivalent to the
EASTL_ALLOCATOR_COPY_ENABLED
macro (defaults to false). - propagate_on_container_move_assignment::value is always true.
- propagate_on_container_swap::value is always true.
Of note, and directly related to your issue is that both list and slist (forward_list) have inconsistent propagation behaviour to the rest of EASTL. Additionally, basic_string also has inconsistent behaviour. Before I can submit a fix I need to do some testing to make sure that EA code is not relying on the current incorrect behaviour for those types. It may be some time before I get to that work.
from eastl.
For reference / visibility the reproducible example, causing compilation error, is:
eastl::list<eastl::unique_ptr<int>> l1;
eastl::list<eastl::unique_ptr<int>> l2;
l1 = eastl::move(l2);
Same for slist.
from eastl.
Related Issues (20)
- Cannot build EASTL_ITC_NS::contiguous_iterator_tag with EASTL_STD_ITERATOR_CATEGORY_ENABLED on C++17 compiler HOT 2
- Outdated/incorrect documentation for use of containers with fixed allocators HOT 1
- Incorrect behaviour of vector (and other) with switched off exceptions HOT 1
- [MSVC][std:c++latest] EASTL failed to build with msvc due to error C2338 on Windows
- Eastl is susport windows kernel? HOT 1
- Building EASTL HOT 1
- [MSVC][std:c++latest] EASTL build failed due to error C2666: 'TestLruCacheInternal::Foo::operator ==': overloaded functions have similar conversions HOT 2
- intrusive_slist is not implemented
- No signed tarball for releases
- Build with Clang15 results in warnings about deprecated builtins HOT 1
- Inquiry about the expected behavior of the comparison operators in RingBuffer HOT 1
- compilation error due to `std::remove_reference` HOT 5
- Tests fail to compile: error: use of undeclared identifier 'getpid'
- Tests fail to compile: error: use of undeclared identifier 'pthread_attr_get_np'
- Tests fail to link: ld: error: undefined symbol: EA::EAMain::InitializeSignalHandler()
- Consider using reset() for fast container teardown - Best pratices HOT 2
- emscripten support? HOT 1
- [Question] Should eastl::unordered_set.reserve not check if a change is required?
- Error of RBTreeDecrement function HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eastl.