Comments (1)
grojo-ea
commented on May 25, 2024
1
Hello,
Thanks for the issue report. This looks like a (long standing) bug to me, I agree that conceptually 2 ring buffers should compare equal if they hold the same elements in the same ring-buffer-order, regardless of actual order in the backing container. I'm surprised this has gone so long without being found.
Your proposed implementation looks good and we'd definitely welcome a PR with a fix. If you haven't already, please fill out the CLA form prior to creating the PR.
Cheers.
from eastl.
Related Issues (20)
- Cannot build EASTL_ITC_NS::contiguous_iterator_tag with EASTL_STD_ITERATOR_CATEGORY_ENABLED on C++17 compiler HOT 2
- Outdated/incorrect documentation for use of containers with fixed allocators HOT 1
- Incorrect behaviour of vector (and other) with switched off exceptions HOT 1
- [MSVC][std:c++latest] EASTL failed to build with msvc due to error C2338 on Windows
- Eastl is susport windows kernel? HOT 1
- Building EASTL HOT 1
- [MSVC][std:c++latest] EASTL build failed due to error C2666: 'TestLruCacheInternal::Foo::operator ==': overloaded functions have similar conversions HOT 2
- intrusive_slist is not implemented
- No signed tarball for releases
- Build with Clang15 results in warnings about deprecated builtins HOT 1
- compilation error due to `std::remove_reference` HOT 5
- Tests fail to compile: error: use of undeclared identifier 'getpid'
- Tests fail to compile: error: use of undeclared identifier 'pthread_attr_get_np'
- Tests fail to link: ld: error: undefined symbol: EA::EAMain::InitializeSignalHandler()
- Consider using reset() for fast container teardown - Best pratices HOT 2
- emscripten support? HOT 1
- [Question] Should eastl::unordered_set.reserve not check if a change is required?
- Error of RBTreeDecrement function HOT 3
- Move semantic dosn't work with eastl::list HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eastl.