Comments (3)
Hello @nnfdnkns,
Thanks for the report. It seems like EAThread has some issues building for Win32 that we need to resolve to actually build EASTL as you describe, but after I hacked around EAThread a bit I was able to compile fine for Win32 on VS2019.
What you describe sounds a lot like what #474 was trying to resolve. I wonder if there's something we're doing incorrectly there.
Can you share the output of running cl /Bv
on your system as described here to get some details on your toolchain?
In my system I can see all the variable declarations you're missing in C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.29.30133\include\ymath.h
. Do you have an equivalent file under your VS installation?
These variables have been removed in a more recent version of MSVC's STL which I believe hasn't shipped, so I'm surprised you're hitting this. The newer version is supposed to be detected by the #if defined(_MSVC_STL_UPDATE) && _MSVC_STL_UPDATE >= 202206L
in our EASTL\numeric_limits.h
.
from eastl.
@grojo-ea Thanks for your quick reply. I have confirmed that this issue has been fixed after we updated the EASTL sha.
But now we still have other same problems as #371. This issue only occurs on x86 bit and we have patched it to unblock testing. Can you help fix it? Thanks.
I can repro the issue on VS2019 16.11.18 with the following build steps:
- open VS2019 x86 native tools command
- git clone https://github.com/electronicarts/EASTL F:\gitP\electronicarts\EASTL
- cd F:\gitP\electronicarts\EASTL
- git submodule sync
- git submodule foreach git reset --hard
- git submodule foreach git clean -xdf
- git submodule update --init
- mkdir build_x86 && cd build_x86
- cmake -G "Visual Studio 16 2019" -A Win32 -DCMAKE_SYSTEM_VERSION=10.0.18362.0 -DEASTL_BUILD_TESTS:BOOL=ON -DEASTL_BUILD_BENCHMARK:BOOL=OFF ..
- msbuild /m /p:Platform=Win32 /p:Configuration=Release EASTL.sln /t:Rebuild
build.log
eastl_x86_c3861.patch.txt
from eastl.
F:\gitP\electronicarts\EASTL\build_x86>cl /Bv
Microsoft (R) C/C++ Optimizing Compiler Version 19.29.30146 for x86
Copyright (C) Microsoft Corporation. All rights reserved.
Compiler Passes:
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\bin\HostX86\x86\cl.exe: Version 19.29.30146.0
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\bin\HostX86\x86\c1.dll: Version 19.29.30146.0
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\bin\HostX86\x86\c1xx.dll: Version 19.29.30146.0
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\bin\HostX86\x86\c2.dll: Version 19.29.30146.0
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\bin\HostX86\x86\c1xx.dll: Version 19.29.30146.0
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\bin\HostX86\x86\link.exe: Version 14.29.30146.0
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\bin\HostX86\x86\mspdb140.dll: Version 14.29.30146.0
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\bin\HostX86\x86\1033\clui.dll: Version 19.29.30146.0
from eastl.
Related Issues (20)
- [MSVC][std:c++latest] EASTL build failed due to error C2666: 'TestLruCacheInternal::Foo::operator ==': overloaded functions have similar conversions HOT 2
- intrusive_slist is not implemented
- No signed tarball for releases
- Build with Clang15 results in warnings about deprecated builtins HOT 1
- Inquiry about the expected behavior of the comparison operators in RingBuffer HOT 1
- compilation error due to `std::remove_reference` HOT 5
- Tests fail to compile: error: use of undeclared identifier 'getpid'
- Tests fail to compile: error: use of undeclared identifier 'pthread_attr_get_np'
- Tests fail to link: ld: error: undefined symbol: EA::EAMain::InitializeSignalHandler()
- Consider using reset() for fast container teardown - Best pratices HOT 2
- emscripten support? HOT 1
- [Question] Should eastl::unordered_set.reserve not check if a change is required?
- Error of RBTreeDecrement function HOT 3
- Move semantic dosn't work with eastl::list HOT 2
- Critical silent bug: vector push back of an own element moves it and calls a copy constructor on the invalidated reference HOT 1
- Overriding make_unique and default_delete HOT 2
- std::thread support HOT 1
- How to run unit tests HOT 2
- eastl::optional::value() casts away qualifiers [-Werror=cast-qual]
- Build Error for Windows ARM64 / ARM64EC (error C2011: 'uint128_t': 'struct' type redefinition)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eastl.