electerious / basicmodal Goto Github PK

The getValues() function only parses inputs. Is there a reason for it to not parse selects?

I can make a PR for it, if there's no philosophical opposition :)

Win10, Internet Explorer

When using basic modal , a pop-up showed that :
“Silverlight was blocked because it is out of date and needs to be updated"

Does basic modal call anything related to silverlight?

I don't see any ability to close modals using the esc key. I think this is a cool project that could definitely take from bootstrap's ARIA use and implement with this project…maybe even better. Thoughts?

You can click buttons multiple times, which always executes the fn of the button. Should be caught to avoid problems.

The screenshot in the README.txt reads "This type of modal can be used to ask the user a questions"
We need a screenshot without the a.

Great and super-fast native modal. I'm a back-end programmer and in no way do I have any contact with front-end but this may be a great feature on the lib itself.

If anyone got time to implement it I'll be glad to spread your code. On other hand, I may try to do it myself in the meantime.

• Add implementation of the title to the modal

Kind regards!

I would like to spruce up the grammar in the README.txt and would like to submit a PR to do so

When viewing the modal window which has an text field on it, when the modal window loads the input will automatically get focus which in turn loads the iOS keyboard. Can we prevent this or have some sort of config property.

Use touchstart/touchend to detect the click faster on mobile.