Empty lines in pom.xml are always indented while the behavior should be configurable about sortpom

[GoogleCodeExporter]

I agree that empty lines should not be indented. I had to tweak the Jdom 
library to support empty lines, and it is not obvious how to remove the 
indentation. Will look into this as soon as possible.

Original comment by [email protected] on 7 Jun 2012 at 6:07

• Changed state: Accepted

[GoogleCodeExporter]

Are you really sure that the indentation for blank lines should be 
configurable? I think they should never be indented.

Created a new version where the empty lines doesn't have indentation. Please 
verify that it works for you before I deploy it to Central.
Download the source from subversion and compile with
mvn clean install -Ddev
and run the plugin with 
mvn com.google.code.sortpom:maven-sortpom-plugin:1.3.1-SNAPSHOT:sort 
-Dsort.keepBlankLines=true

Regards /Björn

Original comment by [email protected] on 7 Jun 2012 at 11:52

• Changed state: Fixed

[GoogleCodeExporter]

Original comment by [email protected] on 7 Jun 2012 at 11:52

• Changed state: Started

[GoogleCodeExporter]

Indeed, the changes seem to work.

I suggested configurability because I'm not sure if truncating whitespace of 
empty lines is globally agreed best practice. Some might want to retain the 
whitespace.

You could turn the approach around and have whitespace removed by default. 
Maybe allow configuring the behavior with truncateEmptyLines property?

Original comment by [email protected] on 10 Jun 2012 at 11:40

[GoogleCodeExporter]

Good suggestion! I'll add the new property and have whitespace removed by 
default.

Original comment by [email protected] on 10 Jun 2012 at 6:18

[GoogleCodeExporter]

Created a new version where the indentation of the blank lines is configurable. 
Default is that blank lines don't have indentation.
Can you please verify this version before I deploy it to Central.

Download the source from subversion and compile with
mvn clean install -Ddev
and run the plugin with 
mvn com.google.code.sortpom:maven-sortpom-plugin:1.3.1-SNAPSHOT:sort 
-Dsort.keepBlankLines=true -Dsort.indentBlankLines=(true|false)

Original comment by [email protected] on 12 Jun 2012 at 7:47

[GoogleCodeExporter]

Verified, works correctly. I think you are safe to publish :)

Original comment by [email protected] on 17 Jun 2012 at 6:19

[GoogleCodeExporter]

Thank for testing! It should reach Central any time now.

Original comment by [email protected] on 17 Jun 2012 at 9:20

• Changed state: Verified

[GoogleCodeExporter]

Original comment by [email protected] on 1 May 2014 at 8:38

• Added labels: Type-Enhancement
• Removed labels: Type-Defect