Coder Social home page Coder Social logo

Comments (7)

Ekryd avatar Ekryd commented on July 26, 2024

🤔 changing the prefix is a quite big breaking change. I wonder if it possible to do some sort of alias? I need to look into this a bit further.

from sortpom.

tonycody avatar tonycody commented on July 26, 2024

🤔 changing the prefix is a quite big breaking change. I wonder if it possible to do some sort of alias? I need to look into this a bit further.

Using properties to configure maven plug-ins is a more elegant way, so each maven plug-in must distinguish which plug-in in the property configuration, otherwise when a large number of maven plug-ins are configured through properties, the configuration will be confusing

from sortpom.

tonycody avatar tonycody commented on July 26, 2024

🤔 changing the prefix is a quite big breaking change. I wonder if it possible to do some sort of alias? I need to look into this a bit further.

sortpom must be supported

from sortpom.

tonycody avatar tonycody commented on July 26, 2024

🤔 changing the prefix is a quite big breaking change. I wonder if it possible to do some sort of alias? I need to look into this a bit further.

From the maven plugin specification, I think even the name needs to be adjusted.

e.g.
com.github.ekryd.maven.plugins:maven-sorter-pom-plugin
mojo: sorter-pom
goal: sort、check、help

Just my personal advice, think this is a better maven plug-in. If the specification were better, maybe there would be more users. You can borrow the style of other popular plugins.
For example: Google, Spring

from sortpom.

Ekryd avatar Ekryd commented on July 26, 2024

Using properties to configure maven plug-ins is a more elegant way, so each maven plug-in must distinguish which plug-in in the property configuration, otherwise when a large number of maven plug-ins are configured through properties, the configuration will be confusing

Out of curiosity, why are you using property configuration for the SortPom plugin instead of having a regular configuration in the pom file?

        <groupId>com.github.ekryd.sortpom</groupId>
        <artifactId>sortpom-maven-plugin</artifactId>
        <version>3.0.0</version>
        <configuration>
          <predefinedSortOrder>custom_1</predefinedSortOrder>
          <lineSeparator>\n</lineSeparator>
          <encoding>${project.build.sourceEncoding}</encoding>
          <sortProperties>true</sortProperties>
          <sortDependencies>scope</sortDependencies>
        </configuration>

from sortpom.

Ekryd avatar Ekryd commented on July 26, 2024

From the maven plugin specification, I think even the name needs to be adjusted.

e.g. com.github.ekryd.maven.plugins:maven-sorter-pom-plugin mojo: sorter-pom goal: sort、check、help

Only Apache plugins are allowed to use maven as prefix: https://maven.apache.org/guides/plugin/guide-java-plugin-development.html#important-notice-plugin-naming-convention-and-apache-maven-trade

from sortpom.

tonycody avatar tonycody commented on July 26, 2024

From the maven plugin specification, I think even the name needs to be adjusted.
e.g. com.github.ekryd.maven.plugins:maven-sorter-pom-plugin mojo: sorter-pom goal: sort、check、help

Only Apache plugins are allowed to use maven as prefix: https://maven.apache.org/guides/plugin/guide-java-plugin-development.html#important-notice-plugin-naming-convention-and-apache-maven-trade

Property name, which has nothing to do with apache

from sortpom.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.