ehmorris / cardslap Goto Github PK

Clicking the cards only triggers the hover event, so you can't even flip them in iOS. There's also no dragging.

also consider inlining a log with comments, such as "Aaron T added a card to the deck"

Lightbox feature or something that doesn't clip the image

the code in _card.html.erb currently breaks the decks show page with the error message undefined method `card_path'

They're not getting the CSS or JS correctly

If the invitee has an account, they'll be authorized to see it. If they don't, they'll have to sign up. Shared decks appears in a users /decks/ page, but look slightly different.

In the future, it might be possible to create a marketplace by allowing users to charge for a shared deck. Cardslap could profit by making a percentage of that charge.

Card creation is slow right now. Maybe include a bunch of forms next to eachother, and a duplicate option.

see errors in console

Tell a user how to flip cards, how to flip all cards, how to create cards, and how to use the memorize pile / reorder.

User would use an image url from the web, but cardslap would upload it to imgur so the image wouldn't depend on an unknown 3rd party site. Would have to make sure user realized this was going on.

List features, provide demo.

all of the reorder-target elements have been removed

That way it retains returns and spaces

Consider a jQuery UI slider. Cards stay square.

Where the cards go by one by one, and you have to guess before flipping them over. Then if you got it right, it goes into the memorized bin. This mode is done in an overlay style ontop of the current deck.

Liek dis: http://railscasts.com/episodes/314-pretty-urls-with-friendlyid

Make it direct to decks#index if logged in, sign_up if not

• cards flippable
• quiz mode accessible
• things sized and margins applied sanely

/deck/deck_id/shares/share_id is too clumsy

Catch errors in controller

Lots of copy pasta right now

the old one doesn't delete and the new one is duplicated

Save on each drag event into or out of the pile. Save on each reorder.

NOTE: don't name the db column for ordering 'order' - it's a reserved word

When dragging from the memorized pile back into the main card area, a card sometimes becomes duplicated in the main card area. Bug is in /app/assets/javascripts/dragdrop.js

Make it clear which is which, add a call to action.

From which they could (in the future) connect their facebook pages (for profile picture / list of friends with which to share a deck), upgrade their acct (if paid accts ever exist), etc.

HTTP error pages all in /public

Instead, ask if they want to create an account, and specify that they need to create an account with the same email that the cardslap was sent to.

If user 1 creates a deck with the title "French verbs" and the slug "french-verbs", and user 2 creates a deck with the same title, user 2's deck slug will be "french-verbs--2"

friendly urls need to be associated with users, otherwise regular ids should just be used