edcd / eddi Goto Github PK

https://forums.frontier.co.uk/showthread.php?t=175338
EDCD/EDMarketConnector#92
Some other projects have implemented a 'safety check' to prevent this bug. We need to review the EDDI source code to see if it had a similar safety check.
The developers of EDMC and EDDiscovery have worked around this by suspending calls to the Companion API while you are carrying rare goods. EDDI may have to do similarly.

Needs to update the ship compartment object?

See cmdrmcdonald/EliteDangerousDataProvider#258 & cmdrmcdonald/EliteDangerousDataProvider#263

This event is not currently supported / needs to be added

Needs to be added.
Is a repair event generated when using the amfu or healing limpets to heal the ship? If not, these events will need to include modifications to the ship object. Needs testing?

Needs to update the ship compartment object?

Tested & verified as working.
There's a pull request open atm with a potential enhancement to separate the letters in the luminosity class string.

See for example: cmdrmcdonald/EliteDangerousDataProvider#276
Option 1: Convert arrays to a concatenated string and send the string to VoiceAttack
Option 2: Recursively iterate through arrays and set variables according to a clear established pattern

New script added. Needs testing to make sure that the cottle script handles all potential objects that can be handled by this event (I wasn't able to locate a complete list and made some guesses while prepping the cottle script)

We need to assess the update delivery mechanism. jgm had it working very painlessly for end users and I would like to preserve that. Of course, unless he is willing and able to grant us control of the relevant update server, we will have to implement some sort of manual transition. This will need thought.

Added using code contributed from the French community (thanks)! Relevant code here: #1

Needs to update the ship compartment object?

See cmdrmcdonald/EliteDangerousDataProvider#252

First of all congratulations for your great work, I use it every day thanks.

In our website EliteesP www.eliteesp.es/ we translate the news of galnet, with the consent of frontier.

Would it be possible to add the galnet news translated into Spanish to EDDI?

We have a news feed. http://eliteesp.es/category/galnet/feed/

This should be one of the last issues closed in the milestone.

See cmdrmcdonald/EliteDangerousDataProvider#260

and provide landing pad locations.

Completed & tested

cmdrmcdonald/EliteDangerousDataProvider#222
cmdrmcdonald/EliteDangerousDataProvider#253

Determine how to send population information to EDDN / EDSM?

Inspired by Darkcyde's mission scripts

I have a very strange error with the proposition of script made for description of rings.
reportbody.reserves is always empty, and i don't know if it's only me.
I try to look how it work and i think that in "Body scanned" we work with BodyScannedEvent.cs, and in "Body report", we work more with DataProviderServices.cs
For exemple, to know if the body is Icy or metalic, we use reportbody.planettype and not the .bodyclass of the event description.
It look like too complex for me to change all of that, so i go in easy way.
In "Body scanned" I add a line:
{SetState('Qual_Reserve', event.reserves)}
and I try to call back with: {state.Qual_Reserve} and it also don't work.
I try again with my {GetState('Qual_Reserve)} and like that I retreive the event.reserves (very strange)

the reserves string are the raw fron edname, so:

• DepletedResources
• LowResources
• CommonResources
• MajorResources
• PristineResources

Update the 'station' object accordingly

• 'WingAdd' Event
• 'WingJoin' Event
• 'WingInvite' Event
• 'WingLeave' Event

New script added. Needs testing to verify it is working as intended.

https://forums.frontier.co.uk/showthread.php/373036-Changes-to-Companion-API-2-4-Open-Beta?p=5859432&viewfull=1#post5859432

• Some modifications for modules are now displayed in /profile, some modifications are not yet included (ship.modules entries have some new fields for engineers' mods.)
• Market & Starsystem controlling Factions & Superpowers displayed in /profile are now correct
• Added current ship's Fighters and / or SRVs to /profile
• Shield damage resistances should now be included on shield generators and boosters
• Display values should now be correct for modifiers where lower values are improvements

Needs to update the ship compartment object?

Suggestion from Syrrianyl:
For the MissionAcceptedEvent, EDDI take actualy the comodity with
Commodity commodity = CommodityDefinitions.FromName(getString(data, "Commodity"))
, is it not better to use the Commodity_Localised with
string commodity = getString(data, "Commodity_Localised");
and now we have also a LocalisedName for the name of the event, so is it better to replace
'string name = getString(data, "Name");'
by
'string name = getString(data, "LocalisedName ");'
or it is better to add a new like this
string localisedname = getString(data, "LocalisedName"); and rework all the MissionAcceptedEvent by adding a value like:
MissionAcceptedEvent(timestamp, missionid, name, faction, destinationsystem, destinationstation, commodity, amount, passengertype, passengerswanted, target, targettype, targetfaction, false, expiry, influence, reputation, localisedname)

A similar approach is likely possible with other events.

Crime definitions (Crime.cs) are not used. We can add humanised crime descriptions as a new variable to 'Bounty incurred' and 'Fine incurred' events in EDDI?

Needs to update the ship compartment object?

I've been trying to make a list of the rewards when redeeming a combat bond, but it seems the event.rewards variable is always empty. Using len(event.rewards) results in zero. There doesn't seem to be any way to know what factions the redeemed bonds are for.

Is this a bug? Could this be caused by a change in the Player Journal? Or is it by design?

No filter is present to prevent all scan events from being processed & spoken

@Genar_Hofoen (Captain's Log) recommended an approach (using python code to show how Captain's log handles these):

@VerticalBlank (EDRefCard) CL2's JournalParser is a QtObject, so I emit a Signal() when encountering an event handled by the parser. Here's the bit of code for navbeaconscan...

    # navbeaconscanevent = False  # Flag to enable or disable scan event notification for GUI.
    # navbeaconscancount = 0  # No. of navbeacon scan events parsed.
    # numbodies = 0  # No. of navbeacon scan events expected.
    def parse_navbeacon_scan(self, line):
        if 'NumBodies' in line:
            self.numbodies = line['NumBodies']
            self.navbeaconscancount = 0
            if self.numbodies > 0:
                self.navbeaconscanevent = True
                self.navBeaconScanStart.emit(self.numbodies)

@VerticalBlank (EDRefCard) Then in my parse_star and parse_planet_scan() functions, I'll look to see if self.navbeaconscan is True, and if so, handle the events differently from a normal, interactive scan event.
@VerticalBlank (EDRefCard) partial bit of code at the end of parse_star_scan() ...

        if self.navbeaconscanevent:
            self.navbeaconscancount += 1
            self.navBeaconScanBodiesLeft.emit(self.navbeaconscancount)
            if self.navbeaconscancount == self.numbodies:
                self.navbeaconscanevent = False
                self.numbodies = 0
                self.navBeaconScanEnd.emit()
            else:
                return
        self.starScanCompleted.emit(line['BodyName'])

Needs to update the ship compartment object?

Needs to be added.
Is a repair event is generated when using the amfu or healing limpets to heal the ship? If not, these events will need to include modifications to the ship object. Needs testing?

See cmdrmcdonald/EliteDangerousDataProvider#99

Can someone confirm that this is bugged and provide a relevant journal entry for this? Just accept a mission with illegal passengers then paste that entry from your journal here. Thanks!

See cmdrmcdonald/EliteDangerousDataProvider#257
cmdrmcdonald/EliteDangerousDataProvider#204
cmdrmcdonald/EliteDangerousDataProvider#214

EDDI writes a "rings" object when rings are present on a body, but the elements within that ring, as defined by Rings.cs, do not appear to be available in the final output: "Name", "Composition", "Mass", "Inner Radius" "Outer Radius"