ecp-veloc / er Goto Github PK

See SCR v3.0rc2 project: https://github.com/LLNL/scr/projects/3

Process

• Resolve necessary issues
• Merge any existing PRs
• Create a commit(s) which updates the project version number in the code and updates references to any dependency versions.
• Merge the commit
• Tag a release on GitHub
• Add release note (can be done after the release is tagged)
• Update the spack package, both with the version hash and the dependency versions.

See SCR v3.0 project: https://github.com/LLNL/scr/projects/4

Process

• Resolve necessary issues
• Merge any existing PRs
• Create a commit(s) which updates the project version number in the code and updates references to any dependency versions.
• Merge the commit
• Tag a release on GitHub
• Add release note (can be done after the release is tagged)
• Update the spack package, both with the version hash and the dependency versions.

See SCR v4.0 project: https://github.com/orgs/LLNL/projects/26

Process

• Merge any outstanding PRs, close any outstanding issues
• Pass GitLab CI tests
• Update the version number in the code, CMakeLists.txt, and any references to dependency versions
• Create a PR with these changes
• Merge the PR
• Tag a release on GitHub
• write some release notes
• Update the spack package: Update hash for download; Update dependency versions

The shuffile file is not correctly restored after rebuilding lost files. It should contain a list of files owned by the rank:

RANK
    1
        FILE
            /dev/shm/user123/scr.1628391/scr.dataset.13/.scr/reddesc.er.1.redset
            /dev/shm/user123/scr.1628391/scr.dataset.13/.scr/reddesc.er.1.xor.grp_1_of_1.mem_2_of_2.redset
            /dev/shm/user123/scr.1628391/scr.dataset.13/rank_1.ckpt
        FILES = 3

But after a rebuild, it only consists of:

RANK = 0

The shuffile file is not part of the set of files protected by the redundancy encoding, so it needs to be restored independently.

It could be reconstructed by reading the list of files from the redset after it has succeeded and before deleting it here:

The simplest approach would be to just recreate the shuffile file on every rank (even those where it already exists) by calling shuffile_create again:

To do that, we need to be able to list the files in the redset. The redset_filelist_get function only returns redundancy encoding files. We will need to add a new function to redset to return the full file list: user files + redundancy files.

I've packaged er for the gentoo overlay guru but our CI failed at testing it
https://bugs.gentoo.org/784644

Build log: https://784644.bugs.gentoo.org/attachment.cgi?id=701382
Test log: https://784644.bugs.gentoo.org/attachment.cgi?id=701385

1/2 Testing: er_test
1/2 Test: er_test
Command: "/usr/bin/mpirun" "-np" "3" "./er_test" "256"
Directory: /var/tmp/portage/sys-cluster/er-0.0.4/work/er-0.0.4_build/test
"er_test" start time: Apr 21 02:51 CEST
Output:
----------------------------------------------------------
REDSET 0.0.5 ABORT: rank 0 on localhost: Number of partner replicas (1) must be in range [1,1) with 1 ranks in set @ /var/tmp/portage/sys-cluster/redset-0.0.5/work/redset-0.0.5/src/redset_partner.c:116
REDSET 0.0.5 ABORT: rank 1 on localhost: Number of partner replicas (1) must be in range [1,1) with 1 ranks in set @ /var/tmp/portage/sys-cluster/redset-0.0.5/work/redset-0.0.5/src/redset_partner.c:116
REDSET 0.0.5 ABORT: rank 2 on localhost: Number of partner replicas (1) must be in range [1,1) with 1 ranks in set @ /var/tmp/portage/sys-cluster/redset-0.0.5/work/redset-0.0.5/src/redset_partner.c:116
--------------------------------------------------------------------------
MPI_ABORT was invoked on rank 0 in communicator MPI_COMM_WORLD
with errorcode -1.

Like redset, the test case will need to be changed to avoid using hostname to define failure groups, if possible.

Main code is causing the issue:

/tmp/veloc/er/src/er.c:322:5: error: ‘REDSET_KEY_CONFIG_DEBUG’ undeclared (first use in this function); did you mean ‘ER_KEY_CONFIG_DEBUG’?
  322 |     REDSET_KEY_CONFIG_DEBUG, er_debug);
      |     ^~~~~~~~~~~~~~~~~~~~~~~

See SCR v3.0 project: https://github.com/llnl/scr/projects/2

Process

• Merge any existing PRs
• Create a commit(s) which updates the project version number in the code and updates references to any dependency versions.
• Merge the commit
• Tag a release on GitHub
• Add release note (can be done after the release is tagged)
• Update the spack package, both with the version hash and the dependency versions.

The ER README.md points users to er.h for usage info, but documentation in that file is currently lacking. We should say which ER functions are collective. For collective functions, we should say which group of processes must call the function, and we should say whether the return code is the same on all procs or not. More description should be provided for input parameters, including adding text showing example calls.

Process

• Resolve necessary issues
• Merge any existing PRs
• Create a commit(s) which updates the project version number in the code, CMakeLists.txt, and updates references to any dependency versions.
• Merge the commit
• Tag a release on GitHub
• Add release note (can be done after the release is tagged)
• Update the spack package, both with the version hash and the dependency versions.