Comments (10)
System theme looks better on Linux. I use it all the time and the feedback is positive, it also better adapts to system theme than no theme at all. So no, let's not retire. Instead, one can fix how it looks on WIndows.
from eclipse.platform.ui.
@mickaelistria what about if me made is special for Linux? I don't think you plan to fix it under windows neither do I and it looks broken.
from eclipse.platform.ui.
Tbh. you should have done this for the default light theme in Linux instead of starting a new theme.
from eclipse.platform.ui.
It's not special to any OS, it's following the color constants retrieved by SWT for the current system. The default light theme use color constants and does not adapt to native theme changes; and the system theme may actually be dark, or green, or light and Eclipse would react.
Ideally, the best would be no theme at all, but things like multiple CTabFolders to identify which folder has focus require a theme at the moment.
That said, if you don't want that theme to be visible under Windows, feel free to add the necessary flags for it. I wouldn't mind. But retiring this theme, I certainly mind, a lot.
from eclipse.platform.ui.
I've thought a bit more about it, as I agree 1 goal is to remove the System theme all together and replace it with native. The blocking issue is the default CTabRendering of e4 that makes it hard to find out which current CTabFolder has focus. I'll try to keep it in mind and hopefully will be able one day to improve that in SWT directly.
I've reported eclipse-platform/eclipse.platform.swt#55 to SWT to fix this problem at its root. When it's fixed, I think we can just remove the System theme and use no theme instead.
from eclipse.platform.ui.
I was trying to reduce the styling to only style the tab folder but only styling the tab results in an endless loop, see #4
from eclipse.platform.ui.
I plan to remove the System theme as soon as eclipse-platform/eclipse.platform.swt#183 is merged.
from eclipse.platform.ui.
Windows looks really good with the forms fix and theming disabled. @mickaelistria do you still plan to delete the system theme, or do you still need it for Linux?
from eclipse.platform.ui.
In any case, I think it's better to remove it and focus attention on SWT itself. I don't plan to maintain the System theme further. So I will try to remove it soon-ish.
from eclipse.platform.ui.
See #142
from eclipse.platform.ui.
Related Issues (20)
- Min-Max area too large in no editor is open HOT 7
- Refresh option only available for projects HOT 7
- Some way to pin a Debug Inspect window HOT 17
- [Find/Replace Overlay] The search-history cannot be accessed from the Overlay HOT 2
- [find/replace dialog] remove Ringtone HOT 1
- [find/replace overlay] Add Editor-Annotations whereever a search-result was found
- [find/replace overlay] Overlay option buttons are not accessible via tab.
- [find/replace overlay] it is not intuitive that enabling RegEx disables Incremental Search
- [find/replace overlay] Separate UI from Controller Logic HOT 2
- [find/replace logic] cannot easily reset the Incremental Base-Location
- [find/replace overlay] incremental base position resets randomly when using "search in selection"
- [find/replace overlay] disabling RegEx resets to the wrong base-location
- [e4] Support registration of PreferencePages with E4 HOT 6
- [find/replace overlay] leaving overlay doesnt remove search scope
- Impossible to change default text font HOT 1
- Ctrl + J / Ctrl + shift + J/Ctrl + k: Incremental search should use the refactored find/replace logic HOT 1
- ensureCleanUpAddonCleansUp test is unstable
- Improve Quick Access filtering - Support ActionProvider HOT 2
- Quick Search: Allow ordering of search results by Path
- random failing: testRemoveQuery
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eclipse.platform.ui.