Refresh option only available for projects about eclipse.platform.ui

[iloveeclipse]

Please provide a PR

[merks]

It's really easy to set up a development environment automatically via the link there:

https://github.com/eclipse-platform/.github/blob/main/CONTRIBUTING.md#creating-an-eclipse-development-environment

[iloveeclipse]

Please try with 4.32 RC2: https://download.eclipse.org/eclipse/downloads/drops4/I20240529-1800

[DaveCarpeneto]

@iloveeclipse : unfortunately still an issue :-(

[DaveCarpeneto]

OK, a very kind & intelligent coworker spotted where the change was introduced: eclipse-platform/eclipse.platform#876

... this change means that the 'refresh' option is now only shown for open projects (prior to this change refresh was shown unless one of the selections was a closed project).

So if refresh was indeed intended to be project-only, then this change results in the 'correct' behavior.

If however the Eclipse project would rather continue to allow the refresh menu item for all resources (which is how the JDT plugin des things in the 'Package Explorer' view, and is super-helpful when you have a massive project & you're only looking to refresh a small section) then further changes to bundles/org.eclipse.ui.navigator.resources/src/org/eclipse/ui/internal/navigator/resources/actions/ResourceMgmtActionProvider.java would be appreciated, perhaps the following:

 -	// To refresh, even if one project is open
 -	if (hasOpenProjects) {
 +	// To refresh if any selection is (a) an open project, or (b) a non-project
 +	if (hasOpenProjects || !isProjectSelection) {
		refreshAction.selectionChanged(selection);
		menu.appendToGroup(ICommonMenuConstants.GROUP_BUILD, refreshAction);
	}

... thoughts? I've not got an environment over here that's convenient to test this, but to me it makes sense & largely allows for the old behavior whilst simultaneously retaining the fix introduced by @vogella via the aforementioned ticket.

[DaveCarpeneto]

Thanks @merks for the link; I'm just checking with my manager as to what legal hoops I need to jump through before I'm allowed to attempt to contribute here.

[iloveeclipse]

Is this fixed via #2003? Please close if that is the case.