Problems View: Last entry rendered italics about eclipse.platform.ui

[iloveeclipse]

@jukzi : which project is it, I can't see this? I can't also observe that on any project I've checked in my workspace.

[jukzi]

its in platform workspace. I think it was where i had set filter to "box"

[iloveeclipse]

I can't get this state with only 7 warnings, every workspace is different.
Any way to have a reproducible example?

[jukzi]

it was in the state after disabling some autobox warnings #1527
currently i am in another state and don't see the problem anymore

[jukzi]

ill try to keep n eye on it and inform you if i found exact reproducer

[raghucssit]

7th element becoming italic only the case limit=6. And for any reason the node was not properly disposed and italic styling was left behind.
@jukzi Did you change the limit to 6 before ?

[jukzi]

no, i think it was on 10000

[jukzi]

maybe there where that many warnings but most of them had been filtered out?

[jukzi]

got it again: current master on all repos. filter to "esource"

limit=1000

[jukzi]

ExpandableNodeCount 9 seems unreasonable high - i don't see anything is getting to the limit

[iloveeclipse]

It is in entire IDE, not only in the view. Close it and check numbers again.

[jukzi]

after IDE restart the node count is 0 and i don't see the problem anymore.

[jukzi]

when i then remove the filter=> nodecount=1, when i add the filter again => nodecount=0 but Problem reappeared

[iloveeclipse]

OK, without filter one of the subtrees size must be over 1000 limit and node is shown, right? Once filter is set, node is not shown anymore, but the last element in same subtree is rendered as it would show the node (in italics)?

[jukzi]

exactly

[iloveeclipse]

How is the Problems view configured, which grouping / sorting ?

[iloveeclipse]

I believe I've managed to reproduce it. What I did is to set the viewer limit to 10, in Problems view disabled grouping (Group By -> None) to have basically a flat table and set filters to show problems per selected project.

Now switching between project A that has ~100 problems and shows "expandable" node to a project B that has < 50 problems, Problems view renders the last element in the tree in italics.

So the best effects I see in JDT UI projects, switching between org.eclipse.jdt.ui and org.eclipse.jdt.ui.unittest.junit with 800 & 2 problems one can see the last (second) element in org.eclipse.jdt.ui.unittest.junit becoming italic, and switching back the second element in org.eclipse.jdt.ui becoming italic too (plus the last one which is "real" expandable node).

The problem with Problems view is the way how elements there are created.
They are reused, and the styles are inherited if reused.

The styles are set in org.eclipse.jface.viewers.ViewerColumn.refresh(ViewerCell), so commenting the line 144 will the problem (but "expandable" node will not be rendered anymore differently). That could probably be fixed in using some different way to change the font used for it, but I remember it wasn't trivial at all to apply any special rendering.

[jukzi]

I did not change sort or grouping Jörg Kubitz

…

Am 19.01.2024 um 16:47 schrieb Andrey Loskutov ***@***.***>:  How is the Problems view configured, which grouping / sorting ? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

[iloveeclipse]

I did not change sort or grouping

Doesn't matter now, since I can reproduce without "extra" filters etc, see above.

We will follow up next week.

@raghucssit : we should think how we can change the rendering in a way it doesn't leave traces on reused elements.

[raghucssit]

I believe I've managed to reproduce it. What I did is to set the viewer limit to 10, in Problems view disabled grouping (Group By -> None) to have basically a flat table and set filters to show problems per selected project.

Now switching between project A that has ~100 problems and shows "expandable" node to a project B that has < 50 problems, Problems view renders the last element in the tree in italics.

So the best effects I see in JDT UI projects, switching between org.eclipse.jdt.ui and org.eclipse.jdt.ui.unittest.junit with 800 & 2 problems one can see the last (second) element in org.eclipse.jdt.ui.unittest.junit becoming italic, and switching back the second element in org.eclipse.jdt.ui becoming italic too (plus the last one which is "real" expandable node).

The problem with Problems view is the way how elements there are created. They are reused, and the styles are inherited if reused.

The styles are set in org.eclipse.jface.viewers.ViewerColumn.refresh(ViewerCell), so commenting the line 144 will the problem (but "expandable" node will not be rendered anymore differently). That could probably be fixed in using some different way to change the font used for it, but I remember it wasn't trivial at all to apply any special rendering.

I can also reproduce this way in problems view.
Initilally No Grouping
Filter = Errors/Warnings on selected resource and children
Set limit=10
Project A with 18 erros + 1 warning.
Probject B - No error/warnings.
Select Project A = 19 items created Flat structure.
Select Project B - Nothing shown.
Select A project again. 19 items created Flat structure
Enable Group By -> Type
Now 2nd group Title is italic.

[raghucssit]

I did not change sort or grouping

Doesn't matter now, since I can reproduce without "extra" filters etc, see above.

We will follow up next week.

@raghucssit : we should think how we can change the rendering in a way it doesn't leave traces on reused elements.

Yes. I will check.

[iloveeclipse]

Yes. I will check.

See #1531