Do not automatically expand Java files in Project Explorer about eclipse.platform.ui

[markozajc]

Normally I don't, but when starting new projects, which I did just recently, this happens quite often.

[HeikoKlare]

Yes, totally makes sense to revert the feature enablement for now. We will try to improve the functionality to context-specifically consider the mentioned situation. I have created #2123 to revert the change.

[HeikoKlare]

The change has now been reverted. Thank you all for giving feedback and for providing use cases with degraded user experience due to the changes that we can take into account when improving the feature.

[jukzi]

@Wittmaxi please check

[Wittmaxi]

A few thoughts on this issue after discussion with @HeikoKlare:
The problem is caused by the new Mechanism in SWT for auto expansion of single children, as merged here: #1742
The best Solution is to add a predicate to the mechanism which then decides when to stop auto-expanding (i.e.: only auto-expand folders)

I am currently only looking into the issues find/replace overlay, I will keep this in the back of my mind for when I have less impotant things to do.

[HeikoKlare]

Just as a minor addition: depending on whether the reported issue is perceived as a severe problem, it would be possible to (temporarily) revert #1742 until we have a mechanism to define custom expansion-termination criteria (as proposed by @Wittmaxi).

[markozajc]

The issue is not severe (it simply clutters up my screen, which is rather annoying), but I would definitely prefer the old behaviour for the time being.

[HeikoKlare]

Just to understand the issue correctly: this kind of auto expansion only happens if you have a package with a single class, doesn't it? So do you have a setup with multiple packages only containing a single class?

[HeikoKlare]

I see. Thank you for the clarification! That's of course a reasonable scenario.

[ddscharfe]

The issue is not severe (it simply clutters up my screen, which is rather annoying), but I would definitely prefer the old behaviour for the time being.

There is a similar issue with this feature in Eclipse CDT. Eclipse CDT allows expanding binary files, and since #1063, they auto-expand if there is only one binary file. This clutters the screen and can also cause performance problems, as expanding binaries can be slow.

[iloveeclipse]

Just as a minor addition: depending on whether the reported issue is perceived as a severe problem, it would be possible to (temporarily) revert #1742 until we have a mechanism to define custom expansion-termination criteria (as proposed by @Wittmaxi).

@HeikoKlare : would be nice to revert for M2 this week or latest fro M3.