echoboomer / terraform-buildkite-plugin Goto Github PK

If you use a stock example and set apply_only: true, the script fails because TF_DIFF is not Bound.

Success! The configuration is valid.
--
  |  
  | /var/lib/buildkite-agent/plugins/github-com-mpestritto-terraform-buildkite-plugin-master/hooks/command: line 195: TF_DIFF: unbound variable
  | 🚨 Error: The command exited with status 1

The plugin requires Terraform files to be located in the project root. Would it be useful to let it run against other locations?

Is your feature request related to an existing problem with the plugin? Please describe.
Do we handle this in the plugin or depend on a different plugin or another process to make private images available to agents?

Describe the solution you'd like.
Perhaps allow simple passing of private Docker registry auth data to the plugin.

Additional context
Add any other context or screenshots about the feature request here.

Right now, this plugin allows custom docker images to be used. However, it assumes that the entrypoint for the docker image will be terraform. This prevents people from using images that were baked with an entrypoint set to anything else.

People who use the local-exec feature in terraform may want to use docker images with dependencies installed that are used in their scripts. Therefore, I propose we ensure the entrypoint is properly set to terraform when we run the docker command.

As an alternative, if you'd like a more general solution, we could allow people to add arbitrary flags to the docker command. This is more powerful and flexible but might not always behave as expected.