ecelis / celso

NextJS + Next-Auth Face detection based framework

celso's Issues

Fix login page camera alignment

Add audit logging for events like register users and logins

Add unit testing to faces (python)

Error on login on fresh install

Stacktrace:

127.0.0.1 - - [21/May/2023 19:49:01] "POST /match HTTP/1.1" 500 -
Traceback (most recent call last):
  File "/home/ecelis/anaconda3/envs/celso/lib/python3.11/site-packages/flask/app.py", line 2213, in __call__
    return self.wsgi_app(environ, start_response)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ecelis/anaconda3/envs/celso/lib/python3.11/site-packages/flask/app.py", line 2193, in wsgi_app
    response = self.handle_exception(e)
               ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ecelis/anaconda3/envs/celso/lib/python3.11/site-packages/flask_cors/extension.py", line 165, in wrapped_function
    return cors_after_request(app.make_response(f(*args, **kwargs)))
                                                ^^^^^^^^^^^^^^^^^^^^
  File "/home/ecelis/anaconda3/envs/celso/lib/python3.11/site-packages/flask/app.py", line 2190, in wsgi_app
    response = self.full_dispatch_request()
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ecelis/anaconda3/envs/celso/lib/python3.11/site-packages/flask/app.py", line 1486, in full_dispatch_request
    rv = self.handle_user_exception(e)
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ecelis/anaconda3/envs/celso/lib/python3.11/site-packages/flask_cors/extension.py", line 165, in wrapped_function
    return cors_after_request(app.make_response(f(*args, **kwargs)))
                                                ^^^^^^^^^^^^^^^^^^^^
  File "/home/ecelis/anaconda3/envs/celso/lib/python3.11/site-packages/flask/app.py", line 1484, in full_dispatch_request
    rv = self.dispatch_request()
         ^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ecelis/anaconda3/envs/celso/lib/python3.11/site-packages/flask/app.py", line 1469, in dispatch_request
    return self.ensure_sync(self.view_functions[rule.endpoint])(**view_args)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ecelis/Projects/celso/faces/faces/__main__.py", line 65, in duplicate
    result = detect.match(json_data['picture'])
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ecelis/Projects/celso/faces/faces/detect.py", line 95, in match
    result = self.match_encodings(image_encodings)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ecelis/Projects/celso/faces/faces/detect.py", line 67, in match_encodings
    return {'error': error, 'success': False}
                     ^^^^^^^^^^^^^^^^^^^^^^^^
UnboundLocalError: cannot access local variable 'error' where it is not associated with a value

No faces detected broken in faces, we might not be handling the ValueError exception properly

Return user picture to display in avatar once signed in

Implement some form of first run to enable registration of admin user

Currently after running bin/create_db.py there is no user registered, hence register page is not accessible.

The user object is not in the web session

Check next-auth

next-auth Session cookie exceeds allowed 4096 bytes.

Implement liveness detection (picture, video, etc)

Retry 3 times to detect a face on registration

Standarize python and javascript mongo necoder for ObjectID the names differ and cause confusion

Standarize faces API responses

Something like

{
  'error': 'string',
  'success': true,
  'data': 'object'
}

Fix TypeError: Cannot destructure property 'name' of '(intermediate value)' as it is undefined.

Register and Login does not refuse with non-human or non-registered

Husky does not run since `.git` directory is outside `web` project

faces/bin/create_db.py missing code after refactor

Unit test `test_get_encodings_no_faces` fail

It always detects one face, with the provided test tests/none.jpg image file. Related to #29

Add testing to flask API

Is your feature request related to a problem? Please describe.
Flask API has no tests, there is no way to know if it always work after changes.

Describe the solution you'd like
Add pytest https://flask.palletsprojects.com/en/2.0.x/testing/

Describe alternatives you've considered
Use OpenAPI and Postman is an alternative.

Encrypt sensitive data suchas username

Add pytest to github actions

Is your feature request related to a problem? Please describe.
Automated testing should be run in github actions

Describe the solution you'd like
Add a github action to run pytest

Create Docker image for arm64

The system might work pulling docker images from register and connect to a networked mongodb host.

Register is broken

Add support for admin role

Some form of RBAC required

Fix Register page camera alignment