Coder Social home page Coder Social logo

icon-banner's People

Contributors

antoinegagnon avatar ebelair avatar ewg777 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

icon-banner's Issues

No such file or directory - which convert (Errno::ENOENT)

Whenever I try to run on Windows, it just won't.. no idea why but here are logs.

PS C:\Users\Jay\Repositories\TrainerDexAssets> icon-banner generate '.\App\TrainerDex-App-Icon.png' --label 'Dev' --color '#ca3755' --font 'C:\Users\Jay\Downloads\Raleway\Raleway-ExtraBold.ttf' --platform 'all'

[21:27:14]: Error accessing file, this might be due to fastlane's directory handling
[21:27:14]: Check out https://docs.fastlane.tools/advanced/#directory-behavior for more details

C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/icon-banner-0.2.2/lib/icon_banner.rb:93:in ``': No such file or directory - which convert (Errno::ENOENT)
        from C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/icon-banner-0.2.2/lib/icon_banner.rb:93:in `validate_libs!'
        from C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/icon-banner-0.2.2/lib/icon_banner/process.rb:13:in `generate'
        from C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/icon-banner-0.2.2/lib/icon_banner.rb:51:in `generate'
        from C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/icon-banner-0.2.2/lib/icon_banner.rb:33:in `block (2 levels) in run'
        from C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/commander-4.6.0/lib/commander/command.rb:187:in `call'
        from C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/commander-4.6.0/lib/commander/command.rb:157:in `run'
        from C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/commander-4.6.0/lib/commander/runner.rb:444:in `run_active_command'
        from C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/fastlane-2.193.1/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb:117:in `run!'
        from C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/commander-4.6.0/lib/commander/delegates.rb:18:in `run!'
        from C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/icon-banner-0.2.2/lib/icon_banner.rb:47:in `run'
        from C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/icon-banner-0.2.2/lib/icon_banner.rb:15:in `start'
        from C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/icon-banner-0.2.2/bin/icon-banner:6:in `<top (required)>'
        from C:/Ruby30-x64/bin/icon-banner:25:in `load'
        from C:/Ruby30-x64/bin/icon-banner:25:in `<main>'

When I do ls App I do get results so it does exist:

PS C:\Users\Jay\Repositories\TrainerDexAssets> ls App

    Directory: C:\Users\Jay\Repositories\TrainerDexAssets\App

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
-a---          09/08/2021    15:33          35685 TrainerDex-App-Icon.png
-a---          09/08/2021    15:33         203383 TrainerDex-App-Splash-Empty.png
-a---          09/08/2021    15:33         215204 TrainerDex-App-Splash.png

Feature Request: user customable BASE_ICON_PATH options

Hi, Thanks for this charming plugin, I think it's more appealing than the well-known badge plugin.

When I use it in Unity exported Android project, icon_banner can't find any icon. This is caused by hard coded BASE_ICON_PATH in its Ruby source code.

While the auto-generated Android has its icons located at src/main/res/mipmap-*/app_icon*.png. This kind of problem is solved in badge by providing a parameter glob, where user can set it to another pattern (e.g. "/**/res/mipmap-*/*.{png,PNG}").

Would you please fix this Android specific issue or add an extra glob equivalent parameter for icon_banner? Thank you very much.

Feature Request: Add option to exclude search icon paths

My projects uses SPM and GoogleLogin.
Google Login embed an AppIcon file for the sample project.
icon-banner tries to add a banner on this icon, which is not editable.

Please add an option to either exclude some paths, or to include only specifics ones.

No implicit conversion of Hash into String on execution

Hi there!
Trying out icon-banner the following error poped up for me:

[13:22:48]: no implicit conversion of Hash into String

+------+--------------------------------+-------------+
|                  fastlane summary                   |
+------+--------------------------------+-------------+
| Step | Action                         | Time (in s) |
+------+--------------------------------+-------------+
| 1    | default_platform               | 0           |
| 2    | Switch to android ibn lane     | 0           |
| 3    | android_increment_version_code | 0           |
| 4    | Switch to android ivn lane     | 0           |
| 5    | android_increment_version_name | 0           |
| ๐Ÿ’ฅ   | icon_banner                    | 1           |
+------+--------------------------------+-------------+

[13:22:48]: fastlane finished with errors

Looking for related GitHub issues on fastlane/fastlane...

โžก๏ธ  app_store_connect_api_key no implicit conversion of Hash into String
    https://github.com/fastlane/fastlane/issues/18176 [closed] 2 ๐Ÿ’ฌ
    6 weeks ago

โžก๏ธ  Can't update fastlane with gem
    https://github.com/fastlane/fastlane/issues/17884 [closed] 3 ๐Ÿ’ฌ
    08 Mar 2021

โžก๏ธ  How to read Shell Curl output into a variable
    https://github.com/fastlane/fastlane/issues/16323 [closed] 3 ๐Ÿ’ฌ
    20 Jun 2020

and 8 more at: https://github.com/fastlane/fastlane/search?q=no%20implicit%20conversion%20of%20Hash%20into%20String&type=Issues&utf8=โœ“

bundler: failed to load command: fastlane (/home/thenewcivilian/Projects/102_app_cargorocket/CargoRocketApp/vendor/bundle/ruby/3.0.0/bin/fastlane)
/home/thenewcivilian/Projects/102_app_cargorocket/CargoRocketApp/vendor/bundle/ruby/3.0.0/gems/mini_magick-4.9.5/lib/mini_magick/image.rb:105:in `initialize': \e[31m[!] no implicit conversion of Hash into String\e[0m (TypeError)

Did I make a mistake in setting up the plugin? Is the current ruby version supported?
I also tried providing the color parameter. Unfortunately It still promted this error.
Please let me know if I can provide more insight into this case.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.