ebeigarts / active_merchant_first_data Goto Github PK

View Code? Open in Web Editor NEW

8.0 8.0 7.0 221 KB

First Data Latvia gateway for Active Merchant

License: MIT License

Ruby 100.00%

active_merchant_first_data's People

Contributors

Stargazers

Watchers

Forkers

janjiss sacristan skoikovs epigene creativegs miks flaumanis

active_merchant_first_data's Issues

Transaction id in the end of redirect_url

Hi there,
Right now I need to add trans_id to params manualy in controller like this:

@gateway.redirect_url + "?trans_id=#{CGI.escape response['transaction_id']}"

I think this transaction id should be added automaticly in redirect_url action, don't you think?
If you agree, then I'll make pull request.

Have a nice day :)

duplicated key at line 265 :msg_type

/Users/girts/.rvm/gems/ruby-2.2.0@cpp/gems/active_merchant_first_data-1.2.0/lib/active_merchant/billing/first_data_gateway.rb:264: warning: duplicated key at line 265 ignored: :msg_type

@ class ActiveMerchant::Billing::FirstDataGateway

      def update_recurring(params = {})
        params = params.reverse_merge(
          :command => :p,
          :amount => 0,
          :currency => default_currency,
          :msg_type => 'SMS',
          :msg_type => 'AUTH',
          :perspayee_gen => 1,
          :perspayee_overwrite => 1
        )
        lookup_currency(params)
        requires!(params, :currency, :client_ip_addr, :description, :biller_client_id, :perspayee_expiry)
        commit(params)
      end