eagerlearn / mod_0_assessment Goto Github PK

Overall really solid work on having solid syntax, naming conventions and commit messages.

However, in terms of following directions I think there is still room for improvement. Specifically, this assessment asked you to create models for an Airport and Vehicle, but it looks like you still used the models from your first assessment?

Please re-do the model portion of the assessment and DM me once you've completed that - thanks!

@Eagerlearn - I just finished reviewing your assessment and there are a few changes I'd like for you to review and update before we consider you technical ready. Please have them complete by EOD Monday and send me a slack message once it's ready for review again:

• In your variables.rb file, you were asked in exercise 3 to assign a variable called is_active to a boolean value. Could you revisit your answer and update?
• In part 3 of the assessment on Modeling Using Hashes, you were asked to put both your model_a.rb and model_b.rb files within the models folder, which I didn't see. Please revisit this and update.
• In your model_b.rb file, you were asked to model a pet, for which I expected to see a hash, modelling a single pet, rather than many pets. Generally hashes should be used to model only one item at a time. Could you revise your file to model a single pet, with appropriate attributes and values associated with it?

Let me know if you have any questions.