Coder Social home page Coder Social logo

epubreader's People

Contributors

e-alfred avatar nextcloud-bot avatar rakekniven avatar sam-19 avatar valdnet avatar voyageur avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

epubreader's Issues

Cannot exit book and return to Nextcloud

Hello, and thank you very much for your work on this epub reader. :-)

I have encountered a problem: when I open a book, the book display lies over the top of the Nextcloud menu bar, and I have not been able to figure out how to close the book. So my only solution so far has been to retype the URL of my NC instance...

Thanks again for your work, and all the best. :-)

Add support to NC 23

This app cannot be installed because the following dependencies are not fulfilled:
Server version 21 or lower is required.

Support for vertical scroll

The only options currently are Left-Right or Right-Left depending on the format, but I'm sure there are others like me who prefers vertical scroll instead.

Installation / Activation not possible on NC 25.0.1

When I try to install this app, I get the following error:

An error occurred during the request. Unable to proceed. Column "oc_reader_bookmarks"."content" is type String, but exceeding the 4.000 length limit.

I'm using Nextcloud 25.0.1 in a Docker environment.

Mess up the profile image upload

When enabled, the profile image upload will not work and just load forever after selecting the crop area.

Docker version 20.10.3, build 48d30b5b32
 "items": [
        [
            "server",
            "version",
            "21.0.0.18"
        ],
        [
            "php",
            "version",
            "7.4.15"
        ],
         [
            "database",
            "type",
            "mysql"
        ],
        [
            "database",
            "version",
            "10.5.9"
        ],
]
Doctrine\DBAL\ArrayParameters\Exception\MissingNamedParameter: Named parameter "file_id" does not have a bound value.
/var/www/3rdparty/doctrine/dbal/src/ExpandArrayParameters.php - line 64:

Doctrine\DBAL\ArrayParameters\Exception\MissingNamedParameter::new()

/var/www/3rdparty/doctrine/dbal/src/SQL/Parser.php - line 79:

Doctrine\DBAL\ExpandArrayParameters->acceptNamedParameter()

/var/www/3rdparty/doctrine/dbal/src/SQL/Parser.php - line 96:

Doctrine\DBAL\SQL\Parser::Doctrine\DBAL\SQL\{closure}("*** sensiti ... *")

/var/www/3rdparty/doctrine/dbal/src/Connection.php - line 1692:

Doctrine\DBAL\SQL\Parser->parse()

/var/www/3rdparty/doctrine/dbal/src/Connection.php - line 1128:

Doctrine\DBAL\Connection->expandArrayParameters()

/var/www/lib/private/DB/Connection.php - line 257:

Doctrine\DBAL\Connection->executeStatement()

/var/www/3rdparty/doctrine/dbal/src/Query/QueryBuilder.php - line 213:

OC\DB\Connection->executeStatement()

/var/www/lib/private/DB/QueryBuilder/QueryBuilder.php - line 286:

Doctrine\DBAL\Query\QueryBuilder->execute()

/data/userapps/epubreader/lib/Hooks.php - line 50:

OC\DB\QueryBuilder\QueryBuilder->execute()

/data/userapps/epubreader/lib/Hooks.php - line 27:

OCA\Epubreader\Hooks::deleteFile()

<<closure>>

OCA\Epubreader\Hooks::OCA\Epubreader\{closure}("*** sensiti ... *")

/var/www/lib/private/Hooks/EmitterTrait.php - line 107:

call_user_func_array()

/var/www/lib/private/Hooks/PublicEmitter.php - line 41:

OC\Hooks\BasicEmitter->emit()

/var/www/lib/private/Files/Node/Root.php - line 139:

OC\Hooks\PublicEmitter->emit()

/var/www/lib/private/Files/Node/Node.php - line 117:

OC\Files\Node\Root->emit()

/var/www/lib/private/Files/Node/File.php - line 130:

OC\Files\Node\Node->sendHooks()

/var/www/lib/private/Files/SimpleFS/SimpleFile.php - line 150:

OC\Files\Node\File->delete()

/var/www/lib/private/Avatar/UserAvatar.php - line 209:

OC\Files\SimpleFS\SimpleFile->delete()

/var/www/lib/private/Avatar/UserAvatar.php - line 106:

OC\Avatar\UserAvatar->remove()

/var/www/core/Controller/AvatarController.php - line 314:

OC\Avatar\UserAvatar->set()

/var/www/lib/private/AppFramework/Http/Dispatcher.php - line 218:

OC\Core\Controller\AvatarController->postCroppedAvatar()

/var/www/lib/private/AppFramework/Http/Dispatcher.php - line 127:

OC\AppFramework\Http\Dispatcher->executeController()

/var/www/lib/private/AppFramework/App.php - line 157:

OC\AppFramework\Http\Dispatcher->dispatch()

/var/www/lib/private/Route/Router.php - line 302:

OC\AppFramework\App::main()

/var/www/lib/base.php - line 993:

OC\Route\Router->match()

/var/www/index.php - line 37:

OC::handleRequest()

Settings were not saved

After any change, the (de)selections (see second screenshot) are not saved:
grafik

These deselections are not saved:
grafik

  • NC 23.0.2
  • EPUB/CBZ/PDF ebook reader 1.4.7

NC22 server error

Updated from NC21 to NC22 and could not log in due to 500 errors

"version":"22.0.0.11","exception":{"Exception":"Error","Message":"Class 'OCP\\User' not found","Code":0,"Trace":[{"file":"/var/www/html/custom_apps/epubreader/lib/Hooks.php","line":41,"function":"get","class":"OCA\\Epubreader\\Config","type":"::","args":["epub_enable","true"]}

had to

occ app:disable epubreader

nextcloud/server#26407

Please read this if you want a working version on NC 27

Hello.

I rewrite a good part of the app on my own repository here : https://git.crystalyx.net/Xefir/epubreader
You can download the latest release here and unzip/untar the archive or clone the repository in your apps directory to get the new working version.

On top of making the app works with the latest version of Nextcloud, I've done some other things like :

  • Typing everything to have a robust and easy development for the future
  • Follow the Nextcloud Coding Standard
  • Add PSALM to have a strict static analysis of the code and detect code mistakes
  • Move the vendor folder to public because vendor is usually used by composer and not for storing publicly JS assets
  • Add a development environment via composer

I won't provide a PR for this or publish my work on the Nextcloud AppStore, for a bunch of reasons :

  • There are way too much modifications to review it properly
  • There is already 3 different apps for epubreader on the store, and I don't want to become this xkcd
  • Moving the vendor folder seems to have broken the nextcloud transifex bot and I don't known how I can fix it (and it won't work without Github anyway)
  • I don't like hosting sources on Github when I can have it at home, that's why we use Nextcloud isn't it ? :D

But I won't make this app mine and I don't want to.
Do not hesitate to grab my work, fork it and put it back on Github if you want !
I will be glad if anyone (and maybe @e-alfred too !) want to continue my work !

Thank you for reading this and have a good time reading your precious books :)

Bookmarks and comments were not saved

Hi there and thank you for this app!
I installed the app today in a hosted environment. I can open an eBook and read it. I can also set a bookmark and see it in the bookmarks in the menu.

When I then close and reopen the book, the bookmark and annotations for the book are gone.

I am running Nextcloud 18.0.4 and installed your app via the nextcloud store.

Am I doing something wrong?

All the best and again thank you for this app!
Achim

Browser hangs

Trying to open an epub (4 Mb) freezes the browser. Tried Chrome and Firefox with no luck.
It only freezes when the ebook already opened before, so i think it has to be a bookmark issue.
Don't know if it happens to anyone else.

Unnecessary popup when opening via a shared link?

Why is there a popup window needed in this situation? If you don't accept the popup, browsers just display the ebook as a mess without mimetype recognition. This isn't very pretty and popups are hardly used anywhere these days. People aren't likely to expect them to be something legitimate. This is on NC 19.0.5.

Page Turn Arrows

Question / Feature request:

Can the page turn arrows be made to ignore zoom level, so that they stay in position regardless of the zoom level?

Can I set the color of the page turn arrows so they stand out more?

Hetzner nextcloud not storing anything (last read position, bookmarks, etc)

Hello,
I got very excited about finding this after looking for a FOSS reader that syncs across devices. This looks like the perfect solution. However it doesn't seem to work on Hetzner managed Nextcloud services: https://www.hetzner.com/storage/storage-share. Nothing is stored.

Clicking the next page,, for example, returns 404 in the console on the url hostname.com/custom_apps/epubreader/bookmark/cursor

Let me know if there is anything I can do to help. The managed service from Hetzner doesn't allow ssh. But this is such an important feature I would imagine stepping over to a self managed instance of nextcloud to get this to work.

many thanks!

add specific font

Hi there,

thank you for your great app.
how we can add a new font to read document ?
when we open document, we can select font (serif, monospace and sans) => where those fonts are taken : from system or app ?
on the other side, we look in directories app, and can find "vendor/epubjs/css/font/", and see font files, but is the use for that ?

Thank in advance for your answers !!
open regards, Nicolas

[Feature Request] EPUB Annotations Sync and Display with Foliate

Foliate is an epub.js based epub reader that stores annotations as JSON files (see here) that can be synced with nextcloud. I am wondering if there is any way to:

  1. Display these annotations in the epub reader when an epub file containing annotations is opened
  2. Store/export my annotations and bookmarks from the web reader in the same format as Foliate so that it can be used offine the reader
  3. Make the two above sync seamlessly so that foliate and the nextcloud web epubreader can work as part of a complete solution for offline and online reading.

Feature request: configurable line spacing

Hi, and thanks again for your work. :-)

Among the configurable features, it would be really cool to be able to configure line spacing. I find the lines are a little too close together for comfortable reading. 1.5x and 2x line spacing would be good for the eyes...

All best wishes. :-)

Nextcloud 21 - support

Hi,

Thanks for this plugin!

I received a NC 21 update recently, and the app is disabled now.

Here the result of the app:check:

occ app:check epubreader
Analysing /var/lib/nextcloud/apps/epubreader/ajax/personal.php
 3 errors
    line   15: OC_JSON - Static method of deprecated class must not be called
    line   16: OC_JSON - Static method of deprecated class must not be called
    line   28: OC_JSON - Static method of deprecated class must not be called
Analysing /var/lib/nextcloud/apps/epubreader/appinfo/app.php
 2 errors
    line   22: OCP\App - Static method of deprecated class must not be called
    line   22: OCP\App::registerPersonal - Method of deprecated class must not be called
Analysing /var/lib/nextcloud/apps/epubreader/lib/Controller/PageController.php
 1 errors
    line  148: == - is discouraged
Analysing /var/lib/nextcloud/apps/epubreader/lib/Hooks.php
 1 errors
    line   68: == - is discouraged
Analysing /var/lib/nextcloud/apps/epubreader/lib/config.php
 4 errors
    line   28: OCP\User - Static method of deprecated class must not be called
    line   28: OCP\User::getUser - Method of deprecated class must not be called
    line   39: OCP\User - Static method of deprecated class must not be called
    line   39: OCP\User::getUser - Method of deprecated class must not be called
App is not compliant

Can you update your app to be compatible with NC21 ?

Thanks !

Certificate "4356" has been revoked

I uninstalled Reader (in Nextcloud 19.0.2) 1.4.2 and when I tried to download and enable it again I got this error message.
"An error occured during the request. Unable to proceed.
Certificate "4356" has been revoked"

Upgraded from Nextcloud 18.0.8 to 19.0.2 and epubreader was working until I removed the app and I tried to reinstall.

Server setup:
Ubuntu 18.04.5 LTS
Nginx 1.19.2
PHP 7.3.21
Nextcloud 19.0.2

Unable to view CBR content. Blank page!

When I try to read a CBR it load the document but the content is blank. I see the navigation bar but that's all.

I'm on NC24.0.4 with EPUB/CBZ/PDF ebook reader 1.4.7

Here is what occur:

image

Explicit icon for day/night mode

Toggling the day/night mode by clicking the author field in the title is not discoverable for users.

A quick solution might be adding a separate icon for switching day/night.

Disable / Enable MIME Types

I’d like epubreader to open EPUBs and CBRs, but not PDFs. (I’d like Nextcloud’s built-in “PDF viewer” to handle PDFs.) Can we disable / enable MIME types?

Cannot page forward to next chapter

Running the new Reader (1.4.2) on Nextcloud 18.0.4, viewing epub books through Firefox 76.0 on Linux Ubuntu (20.04) laptop.

Paging forward and backward "sticks" in places, requiring 2-3-4 clicks or arrow-presses to advance to the next/previous page.

Seems to always happen at chapter divisions. Paging forward from end of Chapter n to start of Chapter n+1 is impossible. I must open the Table of Contents slider and select the next Chapter to advance. Paging backwards sometimes works after 2-4 clicks, sometimes not, requiring TOC navigation.

It looks like this is a brand new clone of the old no-longer-supported Reader. Thanks for reviving it.

Conflicting file names on Windows (blob.js and Blob.js)

Hey,

First off, it's great to see someone pick up development for this app! I would like to hep with developing it further, but there's a file name conflict that prevents me from cloning the app to a Windows machine. In js/lib there are files called blob.js and Blob.js. Both can't simultaneously exist in the same directory on Windows. I'm not sure what these files do actually, renaming blob.js to blobextend.js didn't seem to break anything at least in my short testing. If you could resolve this naming conflict, I could help out with the project. At the moment the first thing to do (in my opinion) is to move the database configuration from the xml file to db/Migrations ASAP, as leaving the xml file in place on current stable can result in serious problems, including permanent data loss.

Best regards,
Sam

Settings for the default viewer are not working with NC 20.0.0

Running epubreader (1.4.2) on Nextcloud 20.0.0 I'm not able to change the default viewer settings for Epub, PDF, CBR/CBZ.
Clicking one of the checkboxes triggers the box and the save dialog opens but never finishes. When the page is reloaded the setting is switched back to the previous state. When activated epubreader is the default viewer for all options (Epub, PDF, CBR/CBZ) and I'm not able to deactivate the settings.

Thanks for your great work.

epub footer popup does not update

In epub files when viewing text with footnote reference/links, if you hover mouse over footnote link at the moment it is showing as a popup info which is great. However if you have more than one footnote link on the same page, the popup does not update when hover on the second or third footnote.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.