dynamic-labs / passport-dynamic Goto Github PK

I'm reviewing the strategy, and will file issues as I notice things that could be modified.

package.json currently lists passport itself as a dependency. I'd recommend it depend on passport-strategy.

Rationale:

It creates a circular dependency when a strategy (which plugs into Passport) depends on Passport itself. Normally, Passport handles this just fine, but it can create conflicts which are hard to diagnose if/when Passport internals change. passport-strategy is a minimal package for strategy subclasses, which isolates from the larger framework.

This should be a minimal change, changing this line to

import { Strategy } from 'passport-strategy';

and updating package dependencies accordingly.