duct-framework / server.figwheel Goto Github PK

lein-figwheel expects files with .js extension inside its source directories to be foreign libraries. And foreign libraries must declare a namespace. In fact, lein-figwheel assumes it, and if it
doesn't find it and can't map the file back to a source .cljs file, it bombs out with a NullPointerException when trying to check for its existance.

This might happen when you put your externs file(s) inside the source directories (this is our case, e.g. https://github.com/magnetcoop/hydrogen-ce/blob/master/src/hyd/client/externs.js)

While lein-figwheel doesn't by default try to process such files on its own, when using Duct server.figwheel it tells lein-figwheel to proccess all files inside the configured source directories (see
https://github.com/duct-framework/server.figwheel/blob/master/src/duct/server/figwheel.clj#L54-L55).

Clearly lein-figwheel should be more robust and handle that situation in a more graceful way[1]. But on the other hand Duct server.figwheel shouldn't be telling lein-figwheel to
process absolutely all files in source directories (but probably just those having .cljs/cljc extension and those declared as foreign libraries).

[1] We have opened a pull request in lein-figwheel regarding this behaviour, see bhauman/lein-figwheel#739

Current implementation reloads the changes when you (reset) the system but figwheel has the feature that it can reload when you save a file which I think is a very nice way of working.

But the live reload on save doesn't work, either it's broken somewhere or there is a reason for this feature not being active. I would just like to know before digging any deeper into this.

figwheel-sidecar 0.5.8 depends on goog.net.jsloader.load
which is removed since Closure Library v20170806.
However, clojurescript 1.9.908 is depends on Closure Library 0.0-20170809-b9c14c6b and this will cause throwing goog.net.jsloader.load not found when reset in duct repl.

Please consider upgrade figwheel to 0.5.13, according to Change Log the use of goog.net.jsloader.load is removed.