duckduckgo / firefox-zeroclickinfo Goto Github PK

Firefox Add-on using the DuckDuckGo Zero-click Info API

License: Other

Makefile 0.74% CSS 12.16% JavaScript 71.14% HTML 15.96%

firefox-zeroclickinfo's Introduction

firefox-zeroclickinfo

This repository has been deprecated. Our current Firefox extension can be found at: https://github.com/duckduckgo/duckduckgo-privacy-extension.

DuckDuckGo enhancements for Firefox.

This addon can

add a handy DuckDuckGo toolbar button to your browser for easy access to !bang tags (removable).
add DuckDuckGo as your default search engine through the address bar, search bar and context right-click menu (reversible).
show DuckDuckGo instant answers on Google/Bing (removable).

Setting the partner parameter

First of all, there is a PARTNER_QUERY_ADDITION constant in lib/main.js that should be set to something like &t=partnerid in order to function properly.

Also, you might want to add the t parameter to the search engine definition which is located at data/search.xml. It usually has a form of <Param name="t" value="partnerid"/>.

You can easily automate both these steps by running

$ make partnerxpi PARTNER_ID=partnerid

which will do both steps for you and provided that you have the Add-on SDK installed it will try to build it for you into a file ddg_for_firefox-partnerid.xpi.

Dependencies

jpm is required.

Install through node: npm install jpm
Update PATH: export PATH="$HOME/node_modules/.bin/:$PATH"

Find more information on MDN

Testing Checklist

Since we don't yet have automated tests, here is a checklist of manual tests to perform:

firefox-zeroclickinfo's People

Contributors

Stargazers

Watchers

firefox-zeroclickinfo's Issues

Give option to customize the hotkey

The default is Alt +G which is not really intuitive and handy IMO.
Regardless it would be great to be able to assign a custom shortcut (like Ctrl +G)
Is it possible?

Port to WebExtensions

Support for XUL extensions will be removed in Firefox 57. This extension needs to be ported to WebExtensions before then, otherwise it will no longer work.

Feature request: preference to not open thanks page after updating

As per title, it would be nice to be able to have an option to disable the thanks page which displays after updating. I'm seeing this page a lot, as I use several profiles.
Has there been many updates recently? There's not many in the changelog, so that's confusing.

AMO license is "custom license" but should be Apache 2.0

The listing on addons.mozilla.org says that this extension is licensed under a "custom license" even though it should say Apache 2.0. See https://addons.mozilla.org/en-US/firefox/addon/duckduckgo-for-firefox/license/1.0.0 and the right-hand sidebar of https://addons.mozilla.org/en-US/firefox/addon/duckduckgo-for-firefox/

Add option to use DuckDuckGo's onion URL

DuckDuckGo provides an onion URL https://3g2upl4pq6kufc4m.onion/

Users that have a profile that connects via TOR might want to use DuckDuckGo's onion URL. It'd be beneficial if there was a checkbox that configured searches to use the onion URL.

Unable Search Repetion with toolbar button popup

When you search a word say, "duck" you get the results. When one leaves the tab open and try to search the exact same word there is no response. The same results when one closes the aforementioned tab.

Links from search results will not open in new tab

i have tried everything i can think of. Setting on firefox are set to open all links in a new tab but duckduckgo search result links are the only thing that will not work.

Addon updates should not change default search engine setting

When the addon is updated, it seems to change the default search engine to DuckDuckGo. While this is OK for new installs (it's one of the features), if the user chooses to have a different search engine as default, that decision should be respected.

From a review comment: https://addons.mozilla.org/en-GB/firefox/addon/duckduckgo-for-firefox/reviews/809465/

Fix popup panel issues on FF 23+

The popup button doesn't work. The problem seems to be around these lines
Clearing the last search term from the popup bar doesn't seem to work either.

New DuckDuckGo Plus add-on doesn't add itself as default search engine or in search engine manager

I'm using Firefox 19 in the Kubuntu. Although I can use the plugin to search in the address bar as well as right-click on the new duck icon I usually have the navigation toolbar minimized and instead search using the "open" and "tabopen" commands from the Vimperator plugin which forces me to use the search engines installed in the search toolbar, which DuckDuckGo Plus doesn't install into. Since the old DuckDuckGo (HTTPS / SSL) add-on is broken [ gives me an Install Error: "Firefox could not install the search plugin from "https://addons.mozilla.org/firefox/downloads/latest/161972/addon-161972-latest.xml?src=search" because an engine with the same name already exists." ] I have had to downgrade to installing instead the DuckDuckGo HTML plug-in search engine which I find less satisfying than the old DuckDuckGo (HTTPS / SSL) plugin. Please either fix the DuckDuckGo (HTTPS / SSL) plugin so it can be installed again or fix DuckDuckGo Plus so it gets added to the search engine list.

The toolbar button does not work in Aurora

When I click the toolbar button I get:

console.warn: ddg_for_firefox: Passing a DOM node to Panel.show() method is an unsupported feature that will be soon replaced. See: https://bugzilla.mozilla.org/show_bug.cgi?id=878877
System JS : ERROR :0 - RequirementError: The option "position" must be a SDK object registered as anchor; or an object with one or more of the following keys set to numeric values: top, right, bottom, left.

... and the popup does not open.

Feature request: UI for changing DDG_URL

Hi,

Would it be possible to add UI to the preferences page to set the URL used in DDG searches?

The extension currently sets DDG_URL to https://duckduckgo.com/?q= but I'd prefer to use a localised and non-filtered URL like https://duckduckgo.com/?kp=-1&kl=uk-en&kad=en_GB&q=

Alternatively, if there are some docs about building the extension on OSX, I am happy to just edit the DDG_URL locally.

Cheers,

Dave

Use HTML5's placeholder attribute for search input

I think it's better to use HTML5 placeholder attribute for showing 'Search DuckDuckGo...' when the search input is empty.

Don't require restart to effect "Answers on Google/Bing" setting

Thank you for providing a setting for "Answers on Google/Bing (on top of links)". Would it be possible to make this setting take effect on change, so that the browser doesn't have to be restarted? For example, AdBlock Plus can do this.

Autocompletion only works on even numbers of characters

https://duck.co/forum/thread/5095/location-bar-in-firefoxhas-a-problem-when-installi

While typing in the location bar, completion (history, bookmarks, etc.) only displays when there is an even number of characters. I've found this is true especially of page titles.
Example: while typing "location bar in" to find that thread:

at "location bar" (12 chars), it is the first and only result
at "location bar " (13 chars), there are no results
"location bar i" (14 chars), one result
"location bar in" (15 chars), no results

Toolbar button not shown in private browsing mode

I use Firefox 53.0.3 on Linux. When private mode is turned on, there is no toolbar button. If private mode is turned off, it works correctly.

Adding a shortcut

Actually there is one click !
It would be nice to add a shortcut so that we can quickly type and search !

"Remember last search in popup" unchecked, but it still appears

Title says it all. I'm using 0.3.8.

The other thing I've noticed is that there is a delay in typing when using the Alt+G shortcut. If I start typing immediately after the search box appears, no characters are entered.

DuckDuckGo Plus for SeaMonkey

We tried to explore the possibility of getting the DuckDuckGo Plus extension working in SeaMonkey but it seems that there are many dependencies that SeaMonkey just does not provide.

It would be still nice to see this extension working on SeaMonkey so if anyone would be willing to tackle this challenge feel free to do so and let us know!

Allow users to create a custom bang list

Feature request:

Let users replace the bangs in this list with ones of their own choosing (E.g. allow them to replace it with a 'My Bangs' list)

For instance, if I frequently use bangs which are not part of this list, I would be able to add them so I can insert the bang by clicking on it.

Place custom !bangs in right-click context menu

So that you could quickly highlight a word and search with your specified bangs without having to copy paste or type.

Not compatible with Firefox 57

With the default settings in Firefox Nightly (57.0a1 2017-08-14) the extension cannot be installed. This may be related to these changes?
https://developer.mozilla.org/en-US/Add-ons/Working_with_multiprocess_Firefox

ReferenceError: window is not defined leads to segfault under firefox 47.0

OS: arch linux
Firefox Version: 47.0
Addon Version: 0.5.2
Other Addons: Vimperator, noscript

console.error: duckduckgo_plus:
Message: ReferenceError: window is not defined
Stack:
exports.create/menuItem<.onMessage@resource://gre/modules/commonjs/toolkit/loader.js -> resource://jid1-zadieub7xozojw-at-jetpack/lib/ddg-askdax.js:41:1
emitOnObject@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:112:9 emit@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:89:38
workerMessageReceived@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/context-menu.js:455:17
emitOnObject@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:112:9
emit@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:89:38
emitOnObject@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:112:9
emit@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:89:38
emitOnObject@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:123:45
emit@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:89:38
messageReceived@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/remote/parent.js:96:37

Assertion failure: !mDoingStableStates, at /build/firefox/src/firefox-47.0/xpcom/base/CycleCollectedJSRuntime.cpp:1305
#1: ???[/usr/lib/firefox/libxul.so +0xe66de4]
#2: ???[/usr/lib/firefox/libxul.so +0xa32ac6]
#3: NS_InvokeByIndex[/usr/lib/firefox/libxul.so +0xa3adda]
#4: ???[/usr/lib/firefox/libxul.so +0xe74443]
#5: ???[/usr/lib/firefox/libxul.so +0xe7b6f4]
#6: ???[/usr/lib/firefox/libxul.so +0x29a9be9]
#7: ???[/usr/lib/firefox/libxul.so +0x29a3e8b]
#8: ???[/usr/lib/firefox/libxul.so +0x29a9825]
#9: ???[/usr/lib/firefox/libxul.so +0x29a9b17]
#10: ???[/usr/lib/firefox/libxul.so +0x29aa15c]
#11: ???[/usr/lib/firefox/libxul.so +0x2bc4be0]
#12: ??? (???:???)

zsh: segmentation fault (core dumped) firefox

DuckDuckGo Plus for Pale Moon?

Hi :)

As Pale Moon is quite a much used browser.. Perhaps you could create a kind of Pale Moon extension - Point is this, Pale Moon does not update to an Australis Firefox code base but it is not outdated.. all security fixes and from time to time chosen features from later code bases get backported.

Thanks!

Instant answers and suggestions are loaded in Private Browsing mode

I see that requests are made in Private Browsing mode to api.duckduckgo.com, to provide Instant Answers in the context menu or to provide search suggestions in the URL bar.

While I do trust DuckDuckGo more than your average search engine, I expect this plugin to respect the user's privacy and not send keywords etc. to DuckDuckGo.

(FF 22.0 / DDG+ 0.2.39) Address bar searches defaulting to Google after addon install

I'm using Firefox 22.0, and I've just installed DuckDuckGo Plus 0.2.39. DuckDuckGo is correctly added to the search box and set as the default search engine. However, entering search keywords in the address bar sends the search to Google instead. This occurs even after deleting Google from the list of list of search engines, and after reinstalling the DDG+ addon.

I manually set the keyword.url config to "https://duckduckgo.com/?q=" in order to force address bar searches to DuckDuckGo. Keyword.url was blank prior to my change, which appears to be the value the addon assigned (search-setting.js, line 178). Should the addon be setting keyword.url to some value other than blank, or is my Firefox install behaving in an unexpected way?

Add option for setting beta.duckduckgo.com as default

As requested by Twitter follower.

Outlook Web App (OWA) Text editor toolbar and email reply cursor missing

When using this addon on Firefox 55.0 (and 54.0) having this addon enabled causes OWA's text editor toolbar to be disabled. It is useful for things like formatting and style of the text. Additionally, in replying to a message the text cursor does not appear at the email thread you are replying to where you would normally begin to type. The only way, it seems, to begin replying is to click lower into the email body and then scroll up to near the top with the arrow keys or paging.

Appearance issue with popup after update to FF 26

I just updated to Firefox 26. The popup still functions, but the appearance is messed up. I'm running v0.3.11 of the add-on. Here's what I'm seeing:

Cloud storage setting

That would be good, if the addon could use a cloud storage passphrase for custom settings in the location bar, the search bar, and the addon search bar.

Enhancement !bangs

People should be able to choose which bangs to show in the popup as quick access.
The current featured listing is just taking space for those NOT wanting them...

Recent Add-on Update Problems

I have noticed some changes in the behaviour of the Add-on after the recent update. The most obvious to me is the "Ask Ducky" menu option that used to appear in the context menu when I highlight some text and right-click on it. This is no longer appearing since the update. I have the 'Answers in Right Click' option enabled in the preferences.

Although I never used it before I cannot see what the Alt+D hotkey does, I also have this set in my preference, but when I press the hotkey it appears to do nothing.

I am using Firefox 21.0 on Windows 7 at the moment. I have many other Add-ons installed, however I tested this with a fresh Firefox profile with no other Add-ons installed and say the same problem.

I really miss the 'Ask Ducky' context menu option. I have several other search plugins installed in the Search Bar and I use the 'Context Search' Firefox Add-on to bring them to my context menu, but it is not as quick as having the 'Ask Ducky' option there. The only problem I found with the 'Ask Ducky' menu is it kept showing random favicons with the 'Ask Ducky', such as the Wikipedia favicon, which would give you the impression that if you clicked on it that it would do a search in Wikipedia, when in fact it sent the search to DDG. So I would have preferred if it always displayed the DDG favicon as these random favicons were quit confusing.

DDG Plus breaks slack

https://our-company.slack.com/messages style suddenly broke for me. Slack support asked me if I use the duckduckgo extension and if so could try to disable it - lo and behold - that did the trick. Why is 'DuckDuckGo Plus' affecting slack.com?

DDG+ Firefox plugin: custom position forgotten on Firefox restart.

The DDG+ Firefox plugin always repositions itself to the very right of the toolbar when Firefox is restarted. This adds an element of annoyance as the mouse pointer is usually resting further away toward the center, requiring a large movement to the edge of the window.

From @jwm-art-net (was in the wrong repo).

Experiment with changing duckduckgo.xml to allow different search engine URLs

The canonical way of adding a search engine with details specified separately omits settings of suggestion endpoints and other important details.

Thus, it might be interesting to see if we could change the duckduckgo.xml file which can be then fed into addEngine(). This way it could be possible to actually change the search engine's URL to reflect user's preferences as requested in #23 for instance.

Right-click menu in toolbar popup's search box

There's currently no right-click menu for the search box (which means no paste for mouse-happy users): https://duck.co/topic/copy-and-paste
Probably applies to the other browsers as well, but I won't spam it.

displaying issue

As you see in the image the bottom of the box is not displayed one line is not readable. I use Windows 7 and Firefox 22.0

Problem with pagemod in Aurora

The error was

Error: The page is currently hidden and can no longer be used until it is visible again.

This might be the solution for that particular problem: http://stackoverflow.com/questions/15502043/addon-sdk-context-menu-and-page-mod-workers

Text rendered white on white in dark themed system gtk with Firefox

I'm using the xfce-dusk GTK theme on Fedora with Firefox 49, but its probably effecting most dark GTK themes on a wide range of systems.

(Request) Ability to Toggle Safesearch

Currently, the family of search addons do not allow the toggling of safesearch (or for that matter modifying the search URL to add the appropriate value to &kp=). I believe that since there are sufficiently many use cases to have a URL parameter for this information, we ought to be able to customize it using the addon, since now firefox has removed keyword.URL.

Thanks in advance.

Feature request: Add ability to have a certain !bang as default search

E.g. an option that prefixes a specified !bang so that the user doesn't have to enter it, e.g. when they're doing multiple searches on a particular site from the address bar.

Requested via Twitter: https://twitter.com/Onoez/status/699234490149949440

DDG search bar focus from toolbar button

Hi ---
I love DDG and use it all the time. Recently I noted that when I click the toolbar search button to get the search bar, I have to actually click in the search bar to give it focus before typing. This behavior doesn't seem intuitive, and in previous versions was not required. Perhaps there is a configuration setting that I can use to restore the preferred behavior? Or do I just need to accept that there will be an extra click required?

I'm running FF 54.0 (32-bit) on Windows 7 Home Premium.

Thanks for your help.

Firefox memory use increases indefinitely with google ad + duckduckgo plus addon 0.4.2

I am running firefox aurora 34.0a2 on a Linux x86-64 platform (Debian 7 stable). I opened this website URL in this firefox:

http://www.newegg.com/All-Laptops-Notebooks/SubCategory/ID-32?Order=PRICE

And voila ... the memory use increases indefinitely. The newegg page embeds two google ad pages (on left bottom and on the bottom center side of the page--not far end but near the end). Once the website loads, the CPU usage remains at 25-40%, and firefox memory use increases from ~200MB to infinity (until OOM). I checked the about:memory page, I traced the source of memory hog to basically the two embedded google pages, whose URLs look like this:

http://www.google.com/uds/afs?q=laptops&oe=utf8&ie=utf8&r=s&client=newegg-browse_js&hl=en&adsafe=high&type=0&fexp=21404%2C7000107&jsei=3&format=n5&ad=n0&nocache=6381410288954547&num=0&output=uds_ads_only&v=3&rurl=http%3A%2F%2Fwww.newegg.com%2FAll-Laptops-Notebooks%2FSubCategory%2FID-32%3FOrder%3DPRICE#slave-1-1

http://www.google.com/uds/afs?q=laptops&oe=utf8&ie=utf8&r=m&fexp=21404%2C7000107&client=newegg-browse_js&hl=en&adsafe=high&type=0&jsei=3&format=w4%7Cn5&ad=w4n5&nocache=5281410288954550&num=0&output=uds_ads_only&v=3&adlh=on&u_his=2&u_tz=-240&dt=1410288954551&u_w=1440&u_h=900&biw=1065&bih=547&psw=1065&psh=547&frm=0&uio=uv3cs1as3-sl0sr0lHaf2ff2st13sd13sv13-sl0lhwi160ff2st13sd13sv13&rurl=http%3A%2F%2Fwww.newegg.com%2FAll-Laptops-Notebooks%2FSubCategory%2FID-32%3FOrder%3DPRICE#master-1

whose memory use grows indefinitely.

On a profile that I am using regularly, I see infinite loop of pulls (GET requests) from duckduckgo.com website, like these urls:

https://duckduckgo.com/i/7813bb13.jpg
https://duckduckgo.com/i/8e674139.jpg
https://duckduckgo.com/i/729be2bb.jpg

and the "Referer" field was one of those google URLs. This memory explosion woe did not happen if I open the website with the same profile but with iceweasel 24.7.0esr-1~deb7u1 provided by Debian.

On a clean profile, which I installed duckduckgo plus and then opened the newegg site above, it did not result in infinite GET requests, but still the memory grows with no limitation. I found that disabling duckduckgo add-on solved this problem. So I think there is a bad interaction between google and duckduckgo's feature, somehow, somewhere. I am passing this on to you for diagnosis, I've done enough on my part to pinpoint the cause.

I am using duckduckgo plus version 0.4.2; it is older version than what Github offers, but that's what available as end-user version (in https://addons.mozilla.org/en-US/firefox/addon/duckduckgo-for-firefox/?src=userprofile ), so I am reporting this problem I'm having against this one.

I have been suffering this infinite memory growth woe for quite some time, without getting to the bottom of it. It is likely that this add-on is the culprit all along. I'll update if I learn some more.

Wirawan

Feature request: Add domain blocking list

Users want this on DuckDuckGo in general so until it gets implemented, this would be good to have in extensions (and eaiser perhaps). Something like this:

User clicks a button to open custom domain tab/box
A custom domain textarea or editable listbox appears
User types in a domain they want to block, e.g. somenastydomain.com
All DuckDuckGo searches now append -somenastydomain.com to the user's search query

Browser local history should be first

"To show you instant answers in the address bar, your typing in the address bar is sent to DuckDuckGo servers automatically. "

I don't think this is a bad feature per-se, as @yegg clearly states no personal information is collected.

The issue is DuckDuckGo's results take precedence over my browser's local history. That's really annoying. I believe those results should appear first, prior to the results pulled from DuckDuckGo's servers.

For example, if I type: gi, it would previously display github.com first. Now it shows results completely unrelated, and I'm forced to arrow-down until I find the correct page, or type the full URL.

Broken 54.0.1 (64-bit)

Alt+G stopped working, works only if you DISABLE/untick the option in settings (so its vice versa).

Also the (-) minimize button next to search field to minimize the bangs and info, etc. stopped working too.

I did not install any new modules that might cause this, this started not working since 2 days ago.