dta9191 / videocodecrename Goto Github PK

My original code printed out the name of the file it was working on, as it opened. It did this using nested if statements for each codec. I recently changed over to searching through a dictionary of known codecs. That new method is cleaner and more efficient, but does not print out the current file name until after the entire operation has completed. This adds the requirement for a progress bar of some sort. Fixing this could remove the need for a progress bar, or at least suppliment one.

Should be looking at the VideoExtensions list to determine if file is most likely a video. Checking every file with ffprobe3 is very slow and wastes time.

stream.codec() already outputs a string, making the format() redundant. Safe to replace with stream.codec().

Found by reddit user. Need a better solution.

To rename files, the program has to be opened by a user who has permission to do so. Opening from a standard desktop or menu shortcut may or may not give necessary permissions. Program needs to attempt to open with elevated privileges and prompt user for credentials. There are currently no warnings that this is a problem, and file rename operations fail without warning.

Left over code from the project before, used as a template. Not used, safe to remove. Non standard serial module called, causing failure to run on stock installations.

Need to find a way to ignore extensions that contain extensions in the VideoExtensions list, but also other things like video production file extenstions.

Output statements using + to combine multiple pieces of data for output can be simplified with f-strings. Found by reddit user.

The serial import from the previous project, used as a template for this one, got left behind, causing extra errors. Causes the program to fail in cases as that isn't a standard Python module, which defeats the goal of this project.

Current video extensions list contains both upper and lower case versions. Can be simplified with <if ex in file.lower()>. Best practice to convert strings to either or lower case, then run comparison checks. Found by user on Reddit.

Outputting to user display requires excessive code. Can use helper methods to clean up and simplify code. Found by reddit user.

Better to use a dictionary to hold list of all the codecs, instead of a variable for each count.

When trying to run against directory full of video project folders, get the following error. Seems to be a problem with certain files. Suspected files contain the extension ".mp4.pfl"

Exception in Tkinter callback
Traceback (most recent call last):
File "/usr/lib/python3.6/tkinter/init.py", line 1705, in call
return self.func(*args)
File "/home/dustin/Documents/Projects/CodecRenameUtility/JUNK.py", line 153, in add_pressed
metadata = FFProbe(str(current))
File "/usr/local/lib/python3.6/dist-packages/ffprobe3/ffprobe.py", line 47, in init
self.streams.append(FFStream(data_lines))
File "/usr/local/lib/python3.6/dist-packages/ffprobe3/ffprobe.py", line 78, in init
(key, val) = a.strip().split('=')
ValueError: not enough values to unpack (expected 2, got 1)

The program will remove the codec from the *.nfo files used by Jellyfin Media Server, as they share the exact name. The nfo file is generated by Jellyfin when scanning new media and includes data about the movie, such as actors, as well as file info. When the names match, Jellyfin may just use the existing nfo file, even though the video file has changed. This would cause issues with displaying resolution and codec data on the client side. When the video file is changed, the nfo file needs to be updated. Jellyfin may notice a file name change and generate a new nfo file, bt this behavior is unconfirmed. The program could simply delete the nf file of the same name, forcing Jellyfin to create a new one. This would require either a server administrator to know the files have changed and force a media scan, or have instant file scanning enabled in Jellyfin. I disable instant scans as they slow down such systems as the Raspberry Pi 400.

Just a minor issue. Could cause confusion when it says something like "Files Renamed: 40", even though none of those were eligible for renaming, and thus were not renamed.

For use on systems with many cores and many files, a more efficient and multithreaded implementation will be needed. At first glance, it appears Python may not be a great language for this. Need to research further.

There are currently 110 files in the Videos directory, but the program shows that there are 112. Searched in Linux Mint using a search for . in file manager.

Without any sort of progress indicator, it's hard to know if the program crashed, or is just running slowly. Considering counting all the files as a first operation, using a spinning progress indicator, then use that count to make a more accurate progress indicator.

I'd like to be able to identify all the files that cause an error with ffprobe3, but then have the ability to remove just that tag, and not a valid codec in the file name.

Found by a reddit user. Need to make a dictionary for variables, then input the dictionary into statements to simplify code.

There is currently no counter for how long it took the operation to run. This would be very useful for development, and interesting to the user. Need to learn how to work with time maths.

Reported by a user on Reddit, confirmed issue and solution on Windows OS. Have to modify how ffprobe3 parses output for the module to work.

Shows more files renamed than there are in the directory.

Duplicate of variable assignment at top of code. Various little inconsistencies, such as mixing of " and '. Found by reddit user.

Need to have it break down the totals for each codec found in the video files.