drx3d / gltf-sample-assets-old Goto Github PK

The production name of this repo will be 'glTF-Sample-Assets'. This change needs to propagate to all README files, either in full repo name and references to 'models' need to change to 'assets'.

I'm trying to commit a branch for the AnisotropyBarnLamp asset, but GitHub Desktop is telling me I don't have write access. Should I open a fork instead?

@pjcozzi : Four of the five models in Models-Issues have Cesium logos. We can identify the image file containing the logo, but that doesn't help when the model is in a single file (Embedded or Binary). We want to avoid stating or implying that the entire thing is CC-BY because that may cause a problem with your mark.

It is also likely that Cesium has mark usage guidelines that prohibit use on 3D models. Khronos is moving to the phrase "visual integrity" when applying marks to 3D models. I would like to come to a level of agreement with respect to licenses where you are comfortable that your IP is protected AND the model appropriates shows off the intended features. Please let me know what that might be.

What image format and what resolutions are recommended for screenshots?

This is not outlined in the readme: https://github.com/DrX3D/glTF-Sample-Assets/blob/main/SubmittingModels.md

However in the past I've been advised by replies in my pull requests to use specific file naming (screenshot.jpg, screenshot_large.jpg), very specific case (e.g. README.md), and resolutions (though I can't remember what the recommended size was).

Perhaps we could align on a standard to recommend?

• JPG format
• At minimum: screenshot.jpg and screenshot_large.jpg, adding additional imagery as needed for the readme.
• screenshot.jpg should be 150 pixels for the largest dimension.
• screenshot_large.jpg should be at minimum 1000 pixels for the largest dimension, or at maximum up to 2000 pixels.

The model https://github.com/DrX3D/glTF-Sample-Assets/tree/main/Assets/IridescentDishWithOlives is out of date.

There is a newer version in this pull request KhronosGroup/glTF-Sample-Models#352 which has been converted to use the KHR_materials_iridescence extension.

The Wayfair logo has also been removed in that PR.

Thanks!