drstearns / passport-uwshib Goto Github PK

I'm trying to create a service provider for my app to work with federated academic network here in Greece and i'm trying to make that work for a couple of days with no success.
So i would like to know if this implementation should have a local installation of the shibboleth software correctly configured to my server, to work. I mean do i need both nodejs passport-uwshib and shibboleth in the same server with the apache module for shibboleth to successfully be an SP?

Thanks in advance DR.

passport.serializeUser dose not set the user object, req.user is always from convertProfileToUser function. But the seralizer data is set to req._passport.session.user.

I think its will add more flexibility for the developer if there is a callback here.
https://github.com/drstearns/passport-uwshib/blob/master/index.js#L102

when using the auto detect feature of IAM Spreg that checks /Shibboleth.sso/Metadata route the eID is expected to be a valid URL, meaning it needs to have "https://" in front of the domain. The example server excludes this but can easily be changed in the example server or could be addressed in the strategy.

Line 66 of the example server:

var strategy = new uwshib.Strategy({
    //Updated entity Id for UW spreg tool
    entityId: 'https://' + domain,
    privateKey: privateKey,
    callbackUrl: loginCallbackUrl,
    domain: domain
    //If your server is not using time.u.washington.edu
    //as its authoritative time server (including if your
    //server is running within the NetID domain!), add
    //the following property setting.
    //This will allow for a small amount of
    //skew between the clocks of the client and the server.
    //
    //acceptedClockSkewMs: 200
});

Thank you for this wonderful project. I found this a bit specific to your institution. I have done some refactoring, added some tests and have created a new generic passport shibboleth library here.

https://github.com/colearnr/passport-shibboleth

Kindly let me know your thoughts.

Best,
Prabhu