Thank you for the pull request! Excellent work. Please review the test results below.
PASS - 39
OK - 4 - accepted with comment (see below)
FAIL - 0
We are accepting this pull request and payment is being made.
Please respond to this ticket with how the process worked for you; any recommendations; and whether you recommend the JSR or another interface for communicating with the jruby model.
Thanks again!
Doug
Description
A program that demonstrates a Scala program calling a standard JRuby/Rails ActiveRecord model object which uses a postgres database. Implement unit tests on the scala program to test the functionality. The calling interface will be the java JSR 223 Scripting API’s.
Requirements
Submission
Work will start by forking the project
post any questions as issues here
Submit work by issuing a git pull request
Requirements can be verified by following these steps on a test machine:
install software prerequisites
do a git clone/git pull
PASS
(optionally) creating an empty database
PASS
running ‘sbt publish-local’ or ‘mvn install’ to run all tests
OK - necessary to run multiple steps to do the tests. But looks very good otherwise!
inspecting the code
PASS
Submission is accepted by accepting the pull request
Submission is rejected by opening a ticket in the developers fork on github
Supported platforms
Either of Apple OSX 10.8.2 or Ubuntu 12.04.3 LTS
Software Versions
Maven 3.0.3 or higher (if used)
Java 1.7.0_x (Oracle java SE)
Jruby 1.7.3 or higher
Rails 4.0.1 or higher
SBT 0.13.0 or higher
Scala 2.10.2 or higher
Postgresql 9.2.2.0 or higher
Software Prerequisites
Assume that the above software versions are already installed on the test machine
Assume the default ‘empty’ postgresql user
Directory Structure scala-jruby-activerecord/ .gitignore README.md pom.xml or sbt project/ (to build,test,package the whole project) model-gem/ (a gem following the ‘bundle gem’ convention) scala-client/ (a scala project following sbt or maven convention) .../resources/ config.__ - a config file holding the db credentials
OK - configuration should be externalized as a properties or other config file in scala