Coder Social home page Coder Social logo

Comments (5)

tboerger avatar tboerger commented on July 3, 2024

If reading env variables gets enabled it's a potential security issue as even the slack webhook gets injected as environment variable.

from drone-slack.

fsouza avatar fsouza commented on July 3, 2024

@tboerger yeah I realized that after playing with a wrapper for a little bit. Perhaps if drone could provide a list of parameters that were passed to the deployment, then the plugin could have that in the context when rendering the template.

from drone-slack.

Morriz avatar Morriz commented on July 3, 2024

/reopen

from drone-slack.

Morriz avatar Morriz commented on July 3, 2024

Can this be reopened? We have multiple drone installations listening to the same repo, and doing CD. We need to report back which instance was successful. This can only be done by parameterizing. Please allow us to use env vars. We are using drone in a controlled environment and no outside meddling with env can happen.

from drone-slack.

tboerger avatar tboerger commented on July 3, 2024

That is just for you the case. I would prefer to integrate the new plugin lib for this plugin, than you would get the system env variables into the template without allowing any env variable as a security issue.

from drone-slack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.