drental / foundryvtt-pf2e-f-is-for-flatfooted Goto Github PK

Foundry 11.307
Pathfinder 5.3.0
Keybind Menagerie 5.3.1

On using F for flat footed, getting error:
Uncaught (in promise) Error: PF2e System | Unrecognized condition: offguard
at ErrorPF2e (pf2e.mjs:1:40717)
at _ActorPF2e2.toggleCondition (pf2e.mjs:28:183159)
at Object.onDown (index.js:104:49)
at KeyboardManager._executeKeybind (foundry.js:2500:66)
at KeyboardManager._processKeyboardContext (foundry.js:2541:33)
at KeyboardManager._handleKeyboardEvent (foundry.js:2599:10)
at foundry.js:2225:54

i love this mod but i didnt see an avoid notice. my players use that alot and id love to get a keybind toggle. many thanks!

Very minor issue: Foundry throws a warning about the "author" attribute. It's been replaced with "authors", and the structure of this new attribute is in the Module Development article (under "Optional Manifest Attributes") on the Foundry VTT site. The next time you update module.json, can you also change to using "authors"?

Ahoi.

Please consider adding return true; to the keybind registration. This would allow users to use something like CTRL+F without having the browser interfere.

Thanks and regards.

Can the keybinds be configured?

Where is the list of keybinds?

1. Select a Token and activate the cover shortcut
2. Click "Close" on the Pop-up
3. Notice how a standard cover is applied and a toast notification states that "no selection was made: cover is inactive"

Core Version: 9.245

System: pf2e 3.3.1.10273 (The PF2e System Developers)

pf2e-f-is-for-flatfooted 3.3.2 (DrentalBot [email protected])

Hello.
Can the players use the keys? I'm trying to assign the "Raise Shield" action but it only works for me as a gamemaster, not as a player.
Thx.

Show Token Art doesn't work. I´ve tried with all other modules deactivated and checked if the other keybinds was working, also tried changing the keys. Apparently the problem is just with Show Token Art.

Currently, when applying Flat-Footed status via keyboard shortcut (e.g. 'F'), it only needs the token to be hovered and not selected.

However, for Cover, it only works on selected token rather than hovered.

Is it possible to make them behave in the same way? Is there a rationale behind this implementation?

Core Version: 9.245

System: pf2e 3.3.1.10273 (The PF2e System Developers)

pf2e-f-is-for-flatfooted 3.3.2 (DrentalBot [email protected])

Offguard Toggle requires Selecting Token. Self explanatory. GM could easily apply Flat-Footed by hovering and hitting F, Offguard does not support that hover functionality.
There is a PR that might fix this already, but adding an issue to tie to it.
This may be fixed by #17

Although it says as GM this will end anyone's turn, I find that any player can advance anyone's turn with this keybind.

(retested with no other modules)

Foundry Virtual Tabletop: Version 10, 10.291
Game System: pf2e, 4.5.1
Active Modules: 1
Performance Mode: 2

OS: Unknown
Client: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/108.0.0.0 Safari/537.36 Edg/108.0.1462.54
GPU: ANGLE (NVIDIA, NVIDIA GeForce GTX 970 Direct3D11 vs_5_0 ps_5_0, D3D11)
Max Texture Size: 16384

Scene: 6000 x 4600 | Grid Size: 100 | Padding Percentage: 0.25
Walls: 0 | Ambient Lights: 0 | Ambient Sounds: 0 | Tiles: 0 | Tokens: 20

Actors: 13 | Items: 46 | Journal: 108 | Rollable Tables: 0 |
Playlists: 0 | Compendium Packs: 73 | Chat Messages: 58

Foundry v. 10.285. The module is fully uninstalled. Go into Add-ons, click "Install Module", find "pF2E Keybind Menagerie", click Install.

Expected outcome: the module installs
Actual outcome: installation error

In the console
Error: Unable to load valid module manifest data from "https://github.com/Drental/foundryvtt-pf2e-f-is-for-flatfooted/releases/download/4.10.0/module.json" The requested manifest at "https://github.com/Drental/foundryvtt-pf2e-f-is-for-flatfooted/releases/download/4.10.0/module.json" did not provide module manifest data. at Module.installPackage (file:///C:/Program%20Files/Foundry%20Virtual%20Tabletop/resources/app/dist/packages/views.mjs:1:1620) at processTicksAndRejections (node:internal/process/task_queues:96:5) at async SetupView.handlePost (file:///C:/Program%20Files/Foundry%20Virtual%20Tabletop/resources/app/dist/server/views/setup.mjs:1:1980) error @ setup.js:292 (anonymous) @ setup.js:345 async function (async) (anonymous) @ setup.js:334 installPackage @ setup.js:276 _onClickPackageInstall @ setup.js:1047 dispatch @ jquery.min.js:2 y.handle @ jquery.min.js:2

Sounds like a good idea to me.