Coder Social home page Coder Social logo

deathtpplus's People

Contributors

dredhorse avatar lonelydime avatar mung3r avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

deathtpplus's Issues

Option to Keep Currency-Item On Death

Because the currency item is stored in the deathchest upon death, my users have no use for the currency option unless they return all the way home (which is a long way because we don't allow other forms of TP), so an option to keep only their currency item in their inventory upon respawn would be very nice.

I tried out the DeathControl plugin for this purpose, but its far more extensive than what I need, and may cause conflicts later down the road. Also, having two separate plugins for the same thing is confusing to users.

Another option (I don't require this but I predict other admins might):
Allow to set a limit on how many of the currency item is retained.

Possible incompatibility with CombatTag plugin.

Possible incompatibility with CombatTag plugin.

11:44:53 [SEVERE] Could not pass event ENTITY_DEATH to DeathTpPlus
java.lang.ClassCastException: org.bukkit.craftbukkit.CraftOfflinePlayer cannot be cast to org.bukkit.entity.Player
        at org.simiancage.DeathTpPlus.models.DeathDetail.<init>(DeathDetail.java:51)
        at org.simiancage.DeathTpPlus.listeners.DTPEntityListener.onEntityDeath(DTPEntityListener.java:31)
        at org.bukkit.plugin.java.JavaPluginLoader$65.execute(JavaPluginLoader.java:718)
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:58)
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:339)
        at org.bukkit.craftbukkit.event.CraftEventFactory.callPlayerDeathEvent(CraftEventFactory.java:320)
        at net.minecraft.server.EntityPlayer.die(EntityPlayer.java:168)
        at net.minecraft.server.EntityLiving.damageEntity(EntityLiving.java:502)
        at net.minecraft.server.EntityHuman.damageEntity(EntityHuman.java:609)
        at net.minecraft.server.EntityPlayer.damageEntity(EntityPlayer.java:210)
        at net.minecraft.server.EntityWolf.a(EntityWolf.java:352)
        at net.minecraft.server.EntityCreature.m_(EntityCreature.java:70)
        at net.minecraft.server.EntityWolf.m_(EntityWolf.java:96)
        at net.minecraft.server.EntityLiving.d(EntityLiving.java:887)
        at net.minecraft.server.EntityAnimal.d(SourceFile:43)
        at net.minecraft.server.EntityWolf.d(EntityWolf.java:137)
        at net.minecraft.server.EntityLiving.w_(EntityLiving.java:297)
        at net.minecraft.server.EntityWolf.w_(EntityWolf.java:165)
        at net.minecraft.server.World.entityJoinedWorld(World.java:1253)
        at net.minecraft.server.WorldServer.entityJoinedWorld(WorldServer.java:107)
        at net.minecraft.server.World.playerJoinedWorld(World.java:1235)
        at net.minecraft.server.World.tickEntities(World.java:1142)
        at net.minecraft.server.MinecraftServer.w(MinecraftServer.java:518)
        at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:425)
        at net.minecraft.server.ThreadServerApplication.run(SourceFile:457)

Refactor / Rewrite the Code a bit more

Mainly need to look at the Tomb and Tombstone implementation and if the packages are really worthwhile.
I don't know if the splitting of the events and listeners really makes sense.
Moving the methods and codes of Tomb and TombStone into helper classes would probably make more sense.

Support no permission server better

well, I changed the permissions which are assigned by default a little bit, but I haven't implemented anything similar to AllowDeathtp which overrules permissions.

Moving this to 3.1 as this could probably done together with refactoring and other bigger changes

Chests Created In Lava/Water/Mid-Air/Walls

Instead of creating the chest in the exact location of the players death...

If the player died in a 'non-air' block (liquids usually, or solids for suffocation), calculate the nearest air block directly above the location of death. (preferably check for 2 air blocks so the chest can be opened if the terrain is protected from modification)

Similarly, if the player died in 'air', check below vertically to place the chest above the first non-air block.

If processor usage becomes a problem (probably not, since it should find the nearest block pretty quickly in MOST circumstances), the distance-to-chest can be limited to a reasonable number.

Searching sideways is too difficult, only search vertically. For large chests, when an air block is detected, search the adjacent 4 blocks for 1 more air block.

Config Option: If a suitable space for the chest(s) cannot be found...
A) Create the block at the location of death, over writing the blocks there. (Default, current behavior)
B) Do not create a chest, destroy the contents (This option is good for servers who do not want chests overwriting special terrain/buildings/features)

TombStones are not automatically deleted

I have it set so my users get a free chest and sign on death but when they don't come back for the tombstone it just stays there and never goes away. I have the time to the default 3600 seconds but the chest is still there days later. Is there something I can do to make the chests go away ? Right now my world is getting littered by tombstones all over the place and I'm the only one that can remove them. Love the plugin

Support for LWC 4

What steps will reproduce the problem?
1.in config, ensure "enableLockette: false"
also ensure "enableLWC: true"
NOTE: LWC settings are all default / using OP native privelages
2.Start server
3.Login to server with OP privelages (not required, but used in testing, anyone with appropriate LWC & DeathTpPlus permissions is able to do so)
4. die by any means
5. approach chest, and right click in hopes to quickloot

What is the expected output? What do you see instead?
What is expected: chest quickloots and empties contents into inventory
What do I see instead:Error log posted below

What version of the product are you using?
CraftBukkit: Recommended Build 1.0.1-R1
LWC: Alpha 4 (build 515)
DeathTpPlus: 3.1

Do you have an error log of what happened?

02:03:40 [SEVERE] Could not pass event PLAYER_INTERACT to DeathTpPlus
java.lang.NoSuchMethodError com.griefcraft.sql.PhysDB.unregisterProtection(I)V
at org.simiancage.DeathTpPlus.helpers.TombStoneHelperDTP.deactivateLWC(T
ombStoneHelperDTP.java:156
at org.simiancage.DeathTpPlus.helpers.TombStoneHelperDTP.destroyTombSton
e(TombStoneHelperDTP.java:481
at org.simiancage.DeathTpPlus.listeners.PlayerListenerDTP.onPlayerIntera
ct(PlayerListenerDTP.java:141
at org.bukkit.plugin.java.JavaPluginLoader$11.execute(JavaPluginLoader.j
ava:335)
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.jav
a:58)
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.j
ava:339)
at org.bukkit.craftbukkit.event.CraftEventFactory.callPlayerInteractEven
t(CraftEventFactory.java:178
at net.minecraft.server.ItemInWorldManager.interact(ItemInWorldManager.j
ava:266)
at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:593)
at net.minecraft.server.Packet15Place.a(SourceFile:39)
at net.minecraft.server.NetworkManager.b(NetworkManager.java:226)
at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:93)
at net.minecraft.server.NetworkListenThread.a(SourceFile:108)
at net.minecraft.server.MinecraftServer.w(MinecraftServer.java:527)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:425)

at net.minecraft.server.ThreadServerApplication.run(SourceFile:457)

Please provide any additional information below.

regressed since Hidendra posted an updated RB for the new Recommended CraftBukkit. LWC 3.54 works as intended, only the new way it's working in 4.x is providing this error.

http://dev.bukkit.org/server-mods/deathtpplus/tickets/19-updated-lwc-incompatibility/

Deathmessages and TombMessages are not reading config files

neither DeathMessages or TombMessages are reading the config files correctly.

looks like getList isn't the correct way to read the structure as the deathmessages will always contain the default messages.

Haven't found a solution yet :-(

Option: Sign & Chest Not Picked Up On Destroy

Allow an option to have the Sign & Chest disappear when destroyed, rather then going into the players inventory. The user does not get them back after they have been used for a tomb/tombstone.

This is particularly helpful for users who have the free sign & chest permission enabled, because they will accumulate a stack of signs and chests over time.

Option: Limit Number of TombStones, not just Tombs

Rather than deleting all chests every X number of deaths, this option would allow free creation of new chests as long as a limit has not been reached. When the limit is reached, the oldest chest is destroyed. Each chest has a death timestamp (at least at time of creation), so calculating oldest should not be difficult.

I do not currently need an option that allows different user groups to have different amounts, although with the future in mind, some users may enjoy this feature. I'm not sure if the permissions you supports allows for info nodes (I use PermissionsBukkit, and will be transitioning to PEX at a later time)

Default MC death messages not being over-ridden

I'm still getting the default MC death messages coming through even though I have enableDeathtp: true and showDeathNotify: true

I'm not seeing DeathTp's messages at all

version 3.3.1597 , CB 1597

I have a feeling that this is a compatibility problem with other plugins rather than an issue with DTP, but I could be wrong.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.