dreamescaper / dotnetseleniumextras.core

Extra utilities for use with the Selenium .NET language bindings

Hi!

I'm Oleksandr, developer from Ukraine, and my country has been invaded by Russian Armed Forces. Please consider donating to the foundations, which I support and donate myself:

https://savelife.in.ua/en/donate-en/

https://prytulafoundation.org/en/donation

dotnetseleniumextras.core's Issues

Request to update Selenium.WebDriver to version 4.14.1

Hi there, a CVE was recently raised with regards to older versions of the Selenium.WebDriver package. The recommendation is to push to a version greater than 4.14.0. As the latest version is now 4.14.1 it makes sense to upgrade to that.

Any chance you'll be able to do this for DotNetSeleniumExtras.PageObjects.Core and DotNetSeleniumExtras.WaitHelpers? As you seem to be the most recently active individual maintaining this suite of packages.

<testsuite failures="1" errors="0" time="0" id="4"
    package="DotNetSeleniumExtras.PageObjects.Core:4.3.0" skipped="0" tests="1"
    timestamp="2023-10-23T12:51:19.782">
    <testcase classname="CVE-2023-5590"
        name="pkg:nuget/[email protected]">
        <failure
            message="cvssV3: HIGH, score: 7.5 (CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H)" />
        <system-out>NULL Pointer Dereference in GitHub repository seleniumhq/selenium prior to
            4.14.0.</system-out>
    </testcase>
</testsuite>
<testsuite failures="1" errors="0" time="0" id="5"
    package="DotNetSeleniumExtras.WaitHelpers:3.11.0" skipped="0" tests="1"
    timestamp="2023-10-23T12:51:19.782">
    <testcase classname="CVE-2023-5590" name="pkg:nuget/[email protected]">
        <failure
            message="cvssV3: HIGH, score: 7.5 (CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H)" />
        <system-out>NULL Pointer Dereference in GitHub repository seleniumhq/selenium prior to
            4.14.0.</system-out>
    </testcase>
</testsuite>

Thanks in Advance!

use of multiple FindsBy annotations not working

I have 2 stages where the locators for one Webelement can differ. (change during development).
So i need to declare 2 different Locators for the same Element.

	`[FindsBy(How = How.Id, Using = "id1") ]
	[FindsBy(How = How.Id, Using = "id-1") ]
	private IWebElement txtBox;
	public GoToKeywords(WebDriverClient driver)
	{
	
		PageFactory.InitElements(driver.GetDriver(),this);
	}`

When the test runs where the first FindsBy (id1) condition is met -> everything is fine
When the test runs on a stage where the second FindsBy (id-1) condition is met -> i get a nullreference exception - it looks like that the second FindsBy is ignored.

FindElements throws StaleElementReferenceException

DotNetSeleniumExtras.Core/src/PageObjects/ByChained.cs

Line 92 in 23c4cac

newElems.AddRange(elem.FindElements(by));

This line may lead to StaleElementReferenceException although FindElements should be a safe method that doesn't throw.

Probably a try with an empty catch would be OK here.

[question] The Page factory function that existed in Appium dotnet-Client has been removed. Could we add PageFactory functionality as an extension?

The Page factory function that existed in Appium dotnet-Client has been removed.

appium/dotnet-client@6294052#diff-a7defabfd952cf3ef940d64c43fbcf3bcf3bcf3bcf3bcf3bcf3bcf3bcf 6BCE6B6

Removed appium dotnet-client pagefacotory property from appium.

FindsByUIAutomatorsAttribute
FindsByAndroidUIAutomatorAttribute

Could we add PageFactory functionality as an extension?

Able to get IWebElement, but I am not able to get IWebElements

Currently I am using below code to get a single web element which is equivalent to driver.FindElement(), is there a way to get a array of web elements equivalent to driver.FindElements()

[FindsBy(How=How.Id,Using = "twotabsearchtextbox")]
private IWebElement _searchInputBox;

call the PageFactory.InitElements(Driver, this), throw exception

Method 'GetDomAttribute' in type 'SeleniumExtras.PageObjects.WebElementProxy' from assembly 'SeleniumExtras.PageObjects, Version=4.0.0.0, Culture=neutral, PublicKeyToken=null' does not have an implementation.

version: 4.0.0-beta1
OS: windows 10
SDK: net core 3.1

PageFactory's Can I set the Timeout setting?

Is that possible to combine PageFactory approach with a custom searching process such as 3 tries for searching with an ExpectedCondition being set and so on?

PageFactory.initElements(new DefaultPageObjectMemberDecorator(driver, 15), this);

or

PageFactory.initElements(new AppiumFieldDecorator(driver, Duration.ofSeconds(30)), this);

[Question] when do you release to nuget 4.0.1 version?

Hello~ Dreamescaper

when do you release to nuget 4.0.1 version?