dreamerslab / jquery.actual

Get the actual width/height of invisible DOM elements with jQuery.

DreamersLab official website

jquery.actual's Issues

package.json parse error

Package.json has a trailing ',' which leads to build fail
"contributors": [
{ "name": "Ben Lin", "email": "[email protected]" },
{ "name": "Erwin Derksen" },
{ "name": "Jon Tara", "email": "[email protected]" },
{ "name": "Matt Hinchliffe", "email": "[email protected]" },
{ "name": "Ryan Millikin" },
{ "name": "Jacob Quant" },
{ "name": "ejn" },
{ "name": "Rudolf", "email": "[email protected]" },
],

Add git link

Suggestion , add a link to this repo in code comments. I found the old version in packed theme plugins file and by looking at this

/*! Copyright 2012, Ben Lin (http://dreamerslab.com/)
 * Licensed under the MIT License (LICENSE.txt).
 *
 * Version: 1.0.17
 *
 * Requires: jQuery >= 1.2.3
 */

I have no idea what the plugin is ( the method actual is ambiguous ) since the file was compiled about year ago and you have many repos.

this would be preferred

/*! Copyright 2012, Ben Lin (http://dreamerslab.com/)
 * Licensed under the MIT License (LICENSE.txt).
 * https://github.com/dreamerslab/jquery.actual
 * Version: 1.0.18
 *
 * Requires: jQuery >= 1.2.3
 */

Any plans on an `includePadding` option?

does not work with 'display: table-cell'

tested on mac os with chrome and safari

options list is empty

Local variable "style" not initialized

Hi, I haven't tested this, but looking at your code, inside the else-branch, there is:

var ..., style;

fix = function (){
    // ...
    style += 'visibility: hidden !important; display: block !important; ';

This should result in style beeing 'undefinedvisibility: hidden ...' which is ruins the visibility-attribute - I guess that's not what you wanted.

Inverted code lines

I bet there is a mistake on the latest release.
Lines 60-61 should go prior line 59 ($this.css( css );)

btw, the plugin seems to still be useful if using jQuery Mobile, even with jQuery 1.7.2.
childs of hidden elements (display:none) return height/width = 0 using the default height()/width() function

Return type inconsistency between jQuery 1.7.2.b1 and 1.7.1

Please take notice of this jQuery bug ticket concerning return types while using the Actual plugin:
http://bugs.jquery.com/ticket/11271

Maybe you know an answer right away.
Best of Luck! And thanks for the nice plugin.

Support native jquery-1.9

Looks like the parts that need to change are as follows:

• jQuery.fn.andSelf() needs to change to jQuery.fn.addBack()
• The demo depends on jQuery.browser, which is no longer supported / available, so this functionality could either depend on jquery-migrate, another library, or some native code. Since it just needs to check if the user agent is MSIE with major version < 7, perhaps it would be acceptable to perform this check natively?

Perhaps

  if( $.browser.msie && $.browser.version < 7 ){

could become

  if( typeof navigator.appName === "string" &&
        navigator.appName === "Microsoft Internet Explorer" &&
        parseFloat(navigator.userAgent.replace(new RegExp(".*MSIE\\D*(\\d+.\\d+).*"), "$1")) < 7
  ){

See http://msdn.microsoft.com/en-us/library/ms537509(v=vs.85).aspx

Update version to 1.0.17 and register as npm package

Hello! Could you please update version number in script files, update bower package and add plugin as npm package? Thank you!

No access to properties

So i need to get the scrollHeight of a hidden element. But this isn't a function so it breaks.