Changes for TB68 about bordercolors-d

[dreadnaut]

Thank you very much Dave, I had no idea of the add-on changes coming up!
I have downloaded the files, I'll prepare a branch for a future version 2.

[revad]

My version (plus the style changes from #1) works in 67b but not the latest 68a: prefs don't save. This may be a temporary regression or there may be more pref changes on the way in 68.

Buttons in the option dialog have no effect. setInt, setColor, not called. (Also affects another addon with a help button.)

[revad]

I raised a bug. It this is indeed a regression it would be better fixed while 68 is still alpha.
https://bugzilla.mozilla.org/show_bug.cgi?id=1542752

If it isn't fixed we can lose the OK, cancel buttons and save the prefs like 'Use BCC Instead C' does

[revad]

It was deliberate - mirroring a change in Firefox.

Geoff Lankow has added that change, and solution to here:
https://thunderbird-webextensions.readthedocs.io/en/latest/how-to/extensions68.html#dialog-events

[revad]

I fixed that by removing the ondialogaccept line and adding into the onLoad function:
document.addEventListener("dialogaccept", function(event) { onAccept(); });

[dreadnaut]

Working on this at the moment, I'll upload a TB68-compatible version later today. Thanks for all the pointers :)

[revad]

FWIW my modified version still works in 68, but the preferences don't work in 69 (colour picker vanished) or 70 (colour picker reappeared but without the account identifers). I didn't investigate why.

[dreadnaut]

Ah, it's going to be a bumpy ride for Thunderbird addons 🤔

I've uploaded release 1.2.0 here on GitHub, and I'll submit it to the Add-on website in a moment.

Closing this for now, thanks for the help!