Comments (7)
I can't double check now—no Linux at hand—but from the video it looks like the color does not actually change when you move the wheel: the RGB/HSL values in the dialog are updated, but not the hexadecimal "Color name". So when you click on "Select", the same color is applied.
Could you check if the value updates correctly in this online demo?
Regarding the options, they are currently in a separate tab because if I try to inline them I get this cryptic error
TypeError: prin.URI is null — ConduitsParent.jsm:123:58
and the identity list doesn't load. So I left it for later to investigate 🙂
from bordercolors-d.
It seems to depend on the initial value. The online demo works - from its red starting point. On the colour picker the little circle is at a corner of the triangle, on the inner edge of the outer ring.
On your addon the initial circle is on the edge of the triangle but not at a corner. Clicking on the outer ring, as I did in the video, does not change the hex colour name, as you saw on the recording. But if I click first elsewhere within the triangle, the colour name does change, and then I can click on the outer ring.
In the online demo, if I manually enter all the initial values from your addon, it misbehaves like the addon. So it appears to be a bug in the widget.
I've played with this for quite a while, but not discovered what value, or combination of values, triggers this effect. And I don't know whether this widget is common to other Linux distros.
On the options tab, I'll see if get the the error you get.
from bordercolors-d.
Options tab:
https://bugzilla.mozilla.org/show_bug.cgi?id=1641577
The workround in comment 16 appears to work.
from bordercolors-d.
Colour picker: I suspect this is a bug in the mozilla gtk widget.
Bug 1489028 is similar - not what we see here - but it's classified as "product:core component:widget:Gtk"
Listing all such bugs I don't see this one.
Perhaps easier to use a colour that doesn't trigger the bug, when you have a Linux system to experiment on.
from bordercolors-d.
Hello there! I made a small change to the fallback color, from a neutral gray to one that should be just off the side. If you have time, could you test the new release?
from bordercolors-d.
Well, it's different. I wrote before "Clicking on the outer ring, as I did in the video, does not change the hex colour name". It does now, so I think it's working OK.
It's not obvious how the gtk colour wheel gizmo is supposed to work. If I want bright green, say, I would expect to just hit that colour on the outer ring and see that reflected in the sample box. But that doesn't have any noticeable effect. You have to move the circle on the inner triangle too to make it more saturated. And to be fair, the tooltip does say exactly that.
Anyway, I think it's probably working as intended, and it's good enough. Most people, like me, will click away until they see a colour they're happy with.
(Took me a while to remember where the prefs were hiding btw.)
from bordercolors-d.
Thanks for testing it! Although not perfect, I don't think there is much else I can do for the moment. I'll close this as fixed.
Regarding the options, I hear you! There's a new release which moves the options in the Add-on tab, but also updates the any open compose windows when you change any settings. With that in place, trying different styles or colors is much easier 🙂
Thanks for finding the options workaround!
from bordercolors-d.
Related Issues (20)
- Switching style in one editor changes the style in other open editor windows as well HOT 3
- Styles do not apply when a color override is in place HOT 5
- Gradients are stretched and sometimes invisible (with long emails) HOT 3
- Update (~9 Nov) has broken text/background colour HOT 4
- Colors do not apply, all borders are black HOT 5
- No identities listed in the add-on options HOT 18
- How to deploy with predefined configuration? HOT 2
- smtp error message and duplication of messages HOT 8
- Per from-address, rather than account HOT 6
- Stop requesting to "Have full, unrestricted access to Thunderbird, and your computer" HOT 3
- Updated translations for 'fr': French (français, langue française) HOT 1
- TB 91 not sending mail while bordercolors-d is active HOT 6
- Not Working HOT 2
- [Windows:] Options are unreadable (black-on-black) HOT 2
- Improve documentation on the Options panel HOT 3
- Only black color HOT 3
- Option to include border lines for replies (as opposed to just new mails) HOT 2
- Choosen colors are not saved HOT 23
- Doesn't work with TB 102.0.3 (64 bits) and cannot be uninstalled HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bordercolors-d.