dragos-efy / efy Goto Github PK

efy.ooo always uses dark by default

Hi,
the icon used to access Efy UI setting is too generic since the same is used by some sites.

1. open a mobile browser (such as firefox)
2. go to https://piped.mha.fi

As you can see, there are two "3 lines button" that are nearly the same except minor colour differences. The top one is for piped's settings, meanwhile the middle one is for Efy UI settings

Thanks
Luca

The icon on the button that opens the UI customization button is just a generic hamburger menu, that may cause confusion for some users as it might be interpreted as some kind of sidebar for the website, not as a theme customization menu.

Current design:

Therefore, I suggest using a different icon. I don't know how icons are handled in EFY, but I found the palette icon on Font Awesome: https://fontawesome.com/icons/palette?f=classic&s=solid

It would be better from a UX perspective, because it is much more descriptive than the generic hamburger menu.

Hello.

I'm using Firefox on Android 11.
In the demo page, close button of an alert has inaccurate positioned X symbol.

Screenshot:

It would be really cool if there was a way to use EFY with static site generators like Hugo, Doks, Jekyll or documentation generators like Docusaurus and MkDocs. I know that an injector feature is coming, but dedicated integrated for the aforementioned frameworks would be nice to see.
For example, Piped is currently migrating to EFY for the UI in their client. If this feature was implemented, they could also use the same coherent design system for all of their other stuff, like the documentation page.

From Readme:

translate it into multiple languages statically (contact me if you know how)

Static translation can be done with json files like in deadlyjack/Acode.

I think, you should create a module named "efy-lang" or "efy-localization" and load&parse needed JSON from efy/lang/ directory.
Then use json keys in code instead of hardcoded strings.
Here is a pseudocode:

// javascript
const lang = 'en-us'
const content = get_file(`${langPath}/${lang}.json`)
const strings = JSON.parse(content)
set_button_text(strings.button_text)

// en-us.json
{
  "button_text": "I'm a button!",
  ...
}

// ru-ru.json
{
  "button_text": "Я - кнопка!",
  ...
}

The language (en-us, ru-ru, de-de, pt-br) can be set in EFY UI settings or/and automatically detected from navigator.language (for old browsers: navigator.userLanguage).

Also, I can help you with translating to Russian.

Hello, I signed up yesterday on https://efy.piped.pages.dev/. Really loving the customization and improvements it offers for the piped UI/UX. Thank you for your work.
I'm using Librewolf (121.0) if that matters.
Unfortunately I am not able to import my subscriptions from either YT or NP. I select the file, it shows the number of subscriptions (122) but when I click import, nothing ever happens (with override selected and not selected). No warning, error out, or message of any kind. I've also tried it connected to / not connected my VPN. Same result either way. Ideas?
(I haven't tried playlists because the instance I have mine on has been down for a day so I haven't been able to export them.)

Hi,
end users should have the possibility to completely disable Efy UI, since as far as I understand it is a customized UI version on top of a working one. A switch button could be integrated near EFY UI logo like this

Thanks
Luca

It would be great to be able to use EFY with the node package manager instead of having to download and update the code manually each time features get added/improvements get made, see https://docs.npmjs.com/creating-and-publishing-scoped-public-packages for reference.

Benefits would be that

1. updates can be done easier
2. it'd improve the code structure in a project that uses EFY because it doesn't require having a efy_ui folder inside

Cheers