dragonexpert / socialgroups Goto Github PK

I have a baseline working for showgroup.php in a test environment, but I don't think it is that optimal and right now it ends up as .html&action=x for any actions. In my test environment I am running a query against socialgroups table collecting the gid and name columns then doing a str_replace in pre_output_page hook.

There should be a setting to show avatars in thread listing.

Add missing language variables.

A feature to restore soft deleted threads and posts. Probably will have it be in the Admin CP.

Similar to normal post and thread counts.

The attributes in the various socialgroups classes should be private. We will have to make sure this doesn't break stuff before implementing.

Have a feature where a group can have its own list of banned users. Said users would not be able to see threads, request to join, etc.

When viewing the User CP you should be able to view what groups you are a member of.

The last post thread id, time, and user should be recorded so the information can be formatted.

Currently the users browsing is hard-coded HTML. It should use a template. For showgroup.php I used forumdisplay_usersbrowsing_user. You'll need to use the variables $user = array(), $invisiblemark because I'd assume we'd want this, and $comma.

In groupcp.php the link to add or remove leaders doesn't show if the person is not the group owner, but there is no actual permission check done if the user goes to the correct url.

Have a Who Posted feature similar to forumdisplay.php. This will not be in the initial release due to requiring a fair bit of Javascript.

I noticed the navigation tabs weren't being output properly in AdminCP -> Social Groups.

• Tabs not output correctly
• Needed to be visually more pleasing
• Deleting a category required double confirmation
• Code Generalization

Right now if no parameter is passed to groupcp.php, some functions will fail. The file should manage what groups a person has access to edit anyway so this should be patched.

Not necessarily needed at first release, but think it could be helpful.

Hook: $plugins->run_hooks("admin_tools_file_verification_check_commit_start");
It would be necessary to globalize the variable $bad_files. $bad_files have the following keys: ['status'] ( changed | missing ), ['path'] = $file_path including the name of the file.

I think the best solution would be to have a file that contains the checksums of all the files the plugin has. Have it do a comparison against that to return any changed files or missing files. Ideally we would also have a plugin hook such that more files are able to be added that aren't part of the core Social Groups.

The files groupcp.php and groupthread.php still have to go through PHP 8 fixes. I understand there are going to be plenty of errors on groupthread.php due to using the build_postbit function which has a lot of PHP 8 issues. The goal is to remove any issues that are caused strictly by our code because once the core of MyBB is fixed for PHP 8, we won't have those errors anymore.

Probably just a typo where an undefined constant occurs.

Hook: admin_home_index_output_message

Will need to be its own table because MyBB doesn't have a good hook location for this information. For sure the number of groups should be something listed. I'm also thinking the total number of threads and posts also should along with how many are today. I don't think recording the number of unapproved is necessary and that would cause an extra query.

Due to the update_forum_stats function not containing any actual hooks, a task file will need to get created that runs. It might not be easy because the table is using dateline as the primary key instead of an auto incremented value.

For some reason it isn't outputting the confirm selection box which makes deleting fail.

Currently the table socialgroup_members stores the uid and the gid. It does not store what time they joined at. This may be a good feature to have because it provides options to sort by the newest members or oldest members.

Right now it doesn't create any categories which can lead to problems if a person tries to create a group before a category is created.

There should be an announcements management screen for the Group CP for individual groups. This would be a lot more intuitive than having to get to the link via showgroup.php.

If a group is locked, there should be a warning on showgroup.php and groupthread.php that says so.

The categories do not often change so using a cache would be a good improvement here because then it will be one less database query. Probably it should be called socialgroups_categories because that way if another plugin caches categories, it won't intefere with it.

It seems the root cause is that there is no tid given.

Currently Social Groups has over 50 templates and that number is only going to increase over time since MyBB doesn't have template conditionals. This makes it much more difficult to find the correct template to edit. My thoughts are to add a tab on the Templates Module of Social Groups that says Edit Templates. It then lets you edit all templates that start with socialgroups_ at one time.

The function socialgroups_generate_table_sql only works with MySQLi at the moment. SQLite and PGSQL need to be implemented.

This would make more sense. Would need to do checks on showgroup.php and groupthread.php to find usages.

In the Admin Module for socialgroup templates, there should be an option to import templates via a file upload. The user would select which theme the templates get modified on in the file upload screen.