doublify / pre-commit-isort Goto Github PK

When run in a hook, isort is changing correct imports to incorrect ones. In particular, it is moving imports from first party code (i.e. this project) into the 3rd party code block.

I'm guessing this is because when the hook runs, it sees only the modified files, therefore is not able to deduce first party imports correctly. This can be fixed by using known_first_party in your isort settings. Is there a better solution? At the very least it would be good if this problem and solution could be documented in the instructions.

I'm trying to run isort via this hook on our codebase, but it performs erratically. Try running the hook on the following file:

la = """
from foo import bar
"""

The hook will insert a newline after the import, in the string. Running isort manually doesn't do that.