dotcypress / ushell Goto Github PK

Hi, I'm not sure about the maintenance status of this crate, but I hit a panic when experimenting with one of the examples from the stm32f4xx-hal crate, so I thought I would still report it.

If the editor buffer is full, and the cursor is not at the end of the buffer, then the firmware will panic when it attempts to insert the character into the editor buffer.

I think the fix is probably to update the if statement here:

Hello,

I'm interested in changing the auto-complete behaviour to make it act more like Linux.

Right now, I have two commands state and status. If I type s and hit tab, it just autocompletes to whichever is first in the StaticAutoComplete object. What I would instead like to have happen is the following:

s <tab>
Autocompletes to stat
<tab> again does nothing
<tab again> lists state status

I hope that makes sense. It's identical behaviour to how my Linux machine operates(bash).

If this behaviour seems like something you'd want, I'm happy to implement it. Just trying to figure out what the Autocomplete trait should look like.

pub trait Autocomplete {
    fn suggest<FO: FnOnce(&str), FM: Fn(&str)>(&self, prefix: &str, one: FO, many: FM);
}

The idea is, you call one if there's a single result, or many if there's more than one result (calling both would be an error). many you'd call once per result. Seems like the most memory-efficient way to do it - even more efficient than the current trait, since it doesn't require instantiating a String<CMD_LEN>