doste / pharodoc Goto Github PK

In pharo there are already a couple of methods:

• subclasses : the direct subclasses of a class
• allSubclasses : all recursive subclasses of a class
• withAllSubclasses : all recursive subclasses of a class plus the class itself

Using these methods you can probably simplify a lot of code ;)

streams automatically advance, so there is usually no need to set it to the end manually.

This will never work in my machine :)

The full project is full of comments "just in case" or "just to test".
It would be nice to remove them.

If those examples are important, they could be turned into example methods.
Or in tests!

There is an automatic formatter in Pharo. You can call it doing right click -> format, or ctrl-shift-f.

An example of badly formatted code is here:

It makes my eyes cry blood!!! :D

It looks like you start generating from the subclasses of the roots you give.
You never generate the page of aClassToShow.
But maybe I'm not seeing right, the indentation problems and the absence of tests really make me doubt :)

How could you write some tests?

I think it is a good exercise.

I understand the problem in the comment, but the question is why you are receiving a nil argument in the first place!
Maybe the problem is not in the concatenation but in the users ;)

https://github.com/doste/PharoDoc/blob/cda606c2a039c09ea44482b88bace022d7176e57/2tPharoDoc/DostePharoDoc.class.st#L39C3-L39C3