dopplerhq / node-sdk Goto Github PK

The STRIPE property is required as part of the Secrets interface. It is not possible to call secrets.update() without including this property.

Example code:

  const input = {
    config: 'dev',
    project: 'test-project',
    secrets: {
      TEST_SECRET: 'test_secret_value',
    }
  };

  const response = await sdk.secrets.update(input);

Resulting error:

Argument of type '{ config: string; project: string; secrets: { TEST_SECRET: string; }; }' is not assignable to parameter of type 'UpdateRequest'.
  Types of property 'secrets' are incompatible.
    Property 'STRIPE' is missing in type '{ TEST_SECRET: string; }' but required in type 'Secrets'.

Please make the STRIPE property optional.

When reading the documentation https://github.com/DopplerHQ/node-sdk/blob/main/src/services/README.md it seems the linking is broken.

If I click on Secrets and then on Get I'm expecting to be sent to the details about using Get for Secrets. But instead I get sent to the first occurrence of the Get title.

This means I need to manually scroll through the documentation to find what I'm looking for. Quite the annoyance.

Hi doppler team! Thanks for making this super useful SDK 🙌 I've used it to make a module for Nuxt.js, the repo can be found here:
https://github.com/JamieCurnow/nuxt-doppler

And it's on npm:
https://www.npmjs.com/package/nuxt-doppler

I've made a PR to Nuxt Modules to get it listed on the modules page on the Nuxt website:
https://nuxt.com/modules
nuxt/modules#829

Hopefully this will encourage more devs to use Dopper for secretOps 😊

I just wanted this to be on your radar to make sure that its ok to use the SDK in this way 🙏

projectMembers.delete doesn't work. Looks like the function is looking for {type_} with underscore, where the URL endpoint has {type}. This also affects projectMembers.get & projectMembers.update.

#16 would fix this, but it was closed as the SDK is auto-generated: